[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jedit-devel
Subject:    [ jEdit-devel ] [ jedit-Patches-1666690 ] patch:feature request
From:       "SourceForge.net" <noreply () sourceforge ! net>
Date:       2007-02-28 5:20:00
Message-ID: E1HMHEO-0006ij-FX () sc8-sf-web5 ! sourceforge ! net
[Download RAW message or body]

Patches item #1666690, was opened at 2007-02-22 17:45
Message generated for change (Comment added) made by vanza
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=1666690&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: texteditor
Group: None
> Status: Closed
> Resolution: Accepted
Priority: 5
Private: No
Submitted By: Joseph Erickson (firstclown)
Assigned to: Nobody/Anonymous (nobody)
Summary: patch:feature request 1574587 -No Undo past file save option

Initial Comment:
Added this as an option on the General Tab of Global Options...  This seems to be a \
more permanent solution than having the user set a macro.

This is coded to the current trunk code.  

Let me know of any problems with it (like, it's not wanted would be one).

----------------------------------------------------------------------

> Comment By: Marcelo Vanzin (vanza)
Date: 2007-02-27 21:20

Message:
Logged In: YES 
user_id=75113
Originator: NO

Well, two comments and a request. :-)

Applied (rev #9037), with a slight modificaton to the method name in
JEditBuffer.java.

----------------------------------------------------------------------

Comment By: Joseph Erickson (firstclown)
Date: 2007-02-27 18:16

Message:
Logged In: YES 
user_id=18174
Originator: YES

That's three comments. :)

Changes have been made.  Sorry about the buffer stuff, I was looking at
making it a buffer and global option and then removed the buffer part.  I
just didn't remove it all the way.  My fault.

I moved it under the editing pane.  It seemed, for me, to fit with some of
the other options under General, like save marker position and save caret
position.  I felt that it had more to do with saving than with undo.  Also
the Editing tab seems to have more to do with the edit mode and the undo
stuff looks a little out of place.  But it doesn't really go anywhere else
either, so editing it is.

The above also seems to apply to the documentation.  When looking at
id="undo-redo", it points the user to the "editing-pane", but that section
only talks about editing modes and doesn't discuss the undo option at all. 
I think I'll look at going back there and filling some things in for it,
but I think that should be in another patch.  For now, I added a very small
blurb to the id="undo-redo" section.
File Added: reset_undo.patch

----------------------------------------------------------------------

Comment By: Marcelo Vanzin (vanza)
Date: 2007-02-26 20:54

Message:
Logged In: YES 
user_id=75113
Originator: NO

Two comments:

- any particular reason why you're storing the property both as a jEdit
property and as a buffer-local property? It seems to me the second one is
not necessary, especially since there's no GUI to change it at the buffer
level (and who would do that?).

- I think the option makes more sense in the "Editing" pane, right below
the "max number of undos" option.

- if it's not asking too much, could you also include an update to the
user's guide documenting the option? Thanks!

----------------------------------------------------------------------

Comment By: Joseph Erickson (firstclown)
Date: 2007-02-23 16:48

Message:
Logged In: YES 
user_id=18174
Originator: YES

Sorry.  This should say feature request 1574587.  Changed it.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=1666690&group_id=588

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
-- 
-----------------------------------------------
jEdit Developers' List
jEdit-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jedit-devel


[prev in list] [next in list] [prev in thread] [next in thread]