[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jedit-cvs
Subject:    [ jEdit-commits ] SF.net SVN: jedit:[22270] jEdit/trunk
From:       Vampire0 () users ! sourceforge ! net
Date:       2012-09-28 17:41:29
Message-ID: E1THeZ7-00055j-PJ () sfp-svn-3 ! v30 ! ch3 ! sourceforge ! com
[Download RAW message or body]

Revision: 22270
          http://jedit.svn.sourceforge.net/jedit/?rev=22270&view=rev
Author:   Vampire0
Date:     2012-09-28 17:41:29 +0000 (Fri, 28 Sep 2012)
Log Message:
-----------
#3017650: Handle menu bar mnemonics with precedence over otherwise defined shortcuts \
as they are shown visually to the user

Modified Paths:
--------------
    jEdit/trunk/doc/CHANGES.txt
    jEdit/trunk/org/gjt/sp/jedit/View.java

Modified: jEdit/trunk/doc/CHANGES.txt
===================================================================
--- jEdit/trunk/doc/CHANGES.txt	2012-09-28 17:33:59 UTC (rev 22269)
+++ jEdit/trunk/doc/CHANGES.txt	2012-09-28 17:41:29 UTC (rev 22270)
@@ -11,6 +11,9 @@
 
 {{{ Bug fixes
 
+- Handle menu bar mnemonics with precedence over otherwise defined shortcuts as
+  they are shown visually to the user (#3528208 Björn "Vampire" Kautler)
+
 - Fix keymap duplication (Björn "Vampire" Kautler)
 
 - Fix broken keymap properties (Björn "Vampire" Kautler)

Modified: jEdit/trunk/org/gjt/sp/jedit/View.java
===================================================================
--- jEdit/trunk/org/gjt/sp/jedit/View.java	2012-09-28 17:33:59 UTC (rev 22269)
+++ jEdit/trunk/org/gjt/sp/jedit/View.java	2012-09-28 17:41:29 UTC (rev 22270)
@@ -1837,8 +1837,21 @@
 	 */
 	private void propertiesChanged()
 	{
-		setJMenuBar(GUIUtilities.loadMenuBar("view.mbar"));
+		JMenuBar mbar = GUIUtilities.loadMenuBar("view.mbar");
 
+		// menu bar mnemonics take precedence over other shortcut definitions
+		for (int i = 0; i < mbar.getMenuCount(); i++)
+		{
+			JMenu menu = mbar.getMenu(i);
+			int mnemonic = menu.getMnemonic();
+			if (mnemonic != 0)
+			{
+				inputHandler.removeKeyBinding("A+" + Character.toLowerCase((char) mnemonic));
+			}
+		}
+
+		setJMenuBar(mbar);
+
 		loadToolBars();
 
 		showFullPath = jEdit.getBooleanProperty("view.showFullPath");

This was sent by the SourceForge.net collaborative development platform, the world's \
largest Open Source development site.


------------------------------------------------------------------------------
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
_______________________________________________
jEdit-CVS mailing list
jEdit-CVS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jedit-cvs


[prev in list] [next in list] [prev in thread] [next in thread]