[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jboss-cvs-commits
Subject:    [jboss-cvs] jbosside/as/plugins/org.jboss.ide.eclipse.as.core/jbosscore/org/jboss/ide/eclipse/as/cor
From:       Robert Stryker <rawblem () gmail ! com>
Date:       2006-05-31 20:42:04
Message-ID: E1FlXW0-0003be-QM () committer01 ! frg ! pub ! inap ! atl ! jboss ! com
[Download RAW message or body]

  User: rawb    
  Date: 06/05/31 16:42:04

  Modified:    as/plugins/org.jboss.ide.eclipse.as.core/jbosscore/org/jboss/ide/eclipse/as/core/model \
  ServerProcessModel.java
  Log:
  Fixed Big error with the Process Model, which inadvertantly allowed other classes \
to create models given any server ID, even if the server did not exist.   
  getModel() signatures have been changed and forcing a creation has been limited
  
  Revision  Changes    Path
  1.2       +3 -4      \
jbosside/as/plugins/org.jboss.ide.eclipse.as.core/jbosscore/org/jboss/ide/eclipse/as/core/model/ServerProcessModel.java
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: ServerProcessModel.java
  ===================================================================
  RCS file: /cvsroot/jboss/jbosside/as/plugins/org.jboss.ide.eclipse.as.core/jbosscore/org/jboss/ide/eclipse/as/core/model/ServerProcessModel.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -b -r1.1 -r1.2
  --- ServerProcessModel.java	31 May 2006 06:21:28 -0000	1.1
  +++ ServerProcessModel.java	31 May 2006 20:42:04 -0000	1.2
  @@ -93,7 +93,7 @@
   		ServerCore.addServerLifecycleListener(this);
   		JBossServer[] servers = JBossServerCore.getAllJBossServers();
   		for( int i = 0; i < servers.length; i++ ) {
  -			getModel(servers[i].getServer().getId());
  +			getModel(servers[i].getServer().getId(), true);
   		}
   	}
   	
  @@ -104,15 +104,14 @@
   	 * @return
   	 */
   	public ServerProcessModelEntity getModel(String key) {
  -		return getModel(key, true);
  +		return getModel(key, false);
   	}
   	
   	
  -	public ServerProcessModelEntity getModel(String key, boolean create) {
  +	private ServerProcessModelEntity getModel(String key, boolean create) {
   		Object o = map.get(key);
   		if( o == null ) {
   			if( !create ) return null;
  -
   			o = new ServerProcessModelEntity(key);
   			map.put(key, (ServerProcessModelEntity)o);
   			processModelChanged((ServerProcessModelEntity)o);
  
  
  


-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk!
Fully trained technicians. The highest number of Red Hat certifications in
the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
_______________________________________________
jboss-cvs-commits mailing list
jboss-cvs-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jboss-cvs-commits


[prev in list] [next in list] [prev in thread] [next in thread]