[prev in list] [next in list] [prev in thread] [next in thread]
List: jboss-cvs-commits
Subject: [jboss-cvs] jmx/src/main/javax/management AndQueryExp.java AnySubStringQueryExp.java AttributeChange
From: Juha Lindfors <juhalindfors () users ! sourceforge ! net>
Date: 2002-09-30 15:16:24
[Download RAW message or body]
User: juhalindfors
Date: 02/09/30 08:16:24
Modified: src/main/javax/management AndQueryExp.java
AnySubStringQueryExp.java
AttributeChangeNotificationFilter.java
BetweenQueryExp.java BinaryComparisonQueryExp.java
BinaryOpValueExp.java FinalSubStringQueryExp.java
InQueryExp.java InitialSubStringQueryExp.java
MBeanException.java MBeanServerFactory.java
MatchQueryExp.java NotQueryExp.java
NumberValueExp.java OrQueryExp.java
QueryExpSupport.java SingleValueExpSupport.java
ValueExpSupport.java
Log:
ran javax.management package thru lint
Revision Changes Path
1.4 +1 -3 jmx/src/main/javax/management/AndQueryExp.java
Index: AndQueryExp.java
===================================================================
RCS file: /cvsroot/jboss/jmx/src/main/javax/management/AndQueryExp.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- AndQueryExp.java 24 Mar 2002 13:12:11 -0000 1.3
+++ AndQueryExp.java 30 Sep 2002 15:16:23 -0000 1.4
@@ -6,8 +6,6 @@
*/
package javax.management;
-import java.io.Serializable;
-
/**
* An And Query Expression.<p>
*
@@ -24,7 +22,7 @@
* </ul>
*
* @author <a href="mailto:Adrian.Brock@HappeningTimes.com">Adrian Brock</a>.
- * @version $Revision: 1.3 $
+ * @version $Revision: 1.4 $
*/
/*package*/ class AndQueryExp
extends QueryExpSupport
1.3 +1 -2 jmx/src/main/javax/management/AnySubStringQueryExp.java
Index: AnySubStringQueryExp.java
===================================================================
RCS file: /cvsroot/jboss/jmx/src/main/javax/management/AnySubStringQueryExp.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- AnySubStringQueryExp.java 24 Mar 2002 13:12:11 -0000 1.2
+++ AnySubStringQueryExp.java 30 Sep 2002 15:16:23 -0000 1.3
@@ -6,7 +6,6 @@
*/
package javax.management;
-import java.io.Serializable;
/**
* An Any Substring Query Expression.<p>
@@ -20,7 +19,7 @@
* </ul>
*
* @author <a href="mailto:Adrian.Brock@HappeningTimes.com">Adrian Brock</a>.
- * @version $Revision: 1.2 $
+ * @version $Revision: 1.3 $
*/
/*package*/ class AnySubStringQueryExp
extends QueryExpSupport
1.5 +1 -3 jmx/src/main/javax/management/AttributeChangeNotificationFilter.java
Index: AttributeChangeNotificationFilter.java
===================================================================
RCS file: /cvsroot/jboss/jmx/src/main/javax/management/AttributeChangeNotificationFilter.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- AttributeChangeNotificationFilter.java 17 Aug 2002 15:48:28 -0000 1.4
+++ AttributeChangeNotificationFilter.java 30 Sep 2002 15:16:23 -0000 1.5
@@ -15,8 +15,6 @@
import java.util.HashSet;
import java.util.Vector;
-import javax.management.AttributeChangeNotification;
-import javax.management.NotificationFilter;
/**
* Notification filter support for attribute change notifications.
@@ -26,7 +24,7 @@
*
* @author <a href="mailto:juha@jboss.org">Juha Lindfors</a>.
* @author a href="mailto:Adrian.Brock@HappeningTimes.com">Adrian Brock</a>
- * @version $Revision: 1.4 $
+ * @version $Revision: 1.5 $
*
* <p><b>Revisions:</b>
* <p><b>20020710 Adrian Brock:</b>
1.4 +1 -2 jmx/src/main/javax/management/BetweenQueryExp.java
Index: BetweenQueryExp.java
===================================================================
RCS file: /cvsroot/jboss/jmx/src/main/javax/management/BetweenQueryExp.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- BetweenQueryExp.java 24 Mar 2002 13:12:11 -0000 1.3
+++ BetweenQueryExp.java 30 Sep 2002 15:16:23 -0000 1.4
@@ -6,7 +6,6 @@
*/
package javax.management;
-import java.io.Serializable;
/**
* A Between Query Expression.<p>
@@ -25,7 +24,7 @@
* </ul>
*
* @author <a href="mailto:Adrian.Brock@HappeningTimes.com">Adrian Brock</a>.
- * @version $Revision: 1.3 $
+ * @version $Revision: 1.4 $
*/
/*package*/ class BetweenQueryExp
extends QueryExpSupport
1.4 +9 -11 jmx/src/main/javax/management/BinaryComparisonQueryExp.java
Index: BinaryComparisonQueryExp.java
===================================================================
RCS file: /cvsroot/jboss/jmx/src/main/javax/management/BinaryComparisonQueryExp.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- BinaryComparisonQueryExp.java 24 Mar 2002 13:12:11 -0000 1.3
+++ BinaryComparisonQueryExp.java 30 Sep 2002 15:16:23 -0000 1.4
@@ -20,12 +20,11 @@
* </ul>
*
* @author <a href="mailto:Adrian.Brock@HappeningTimes.com">Adrian Brock</a>.
- * @version $Revision: 1.3 $
+ * @version $Revision: 1.4 $
*/
/*package*/ class BinaryComparisonQueryExp
extends QueryExpSupport
{
- // Constants ---------------------------------------------------
// Attributes --------------------------------------------------
@@ -44,7 +43,6 @@
*/
ValueExp second;
- // Static -----------------------------------------------------
// Constructors ------------------------------------------------
@@ -94,6 +92,9 @@
case Query.EQ:
return ((NumberValueExp)testFirst).getDoubleValue() ==
((NumberValueExp)testSecond).getDoubleValue();
+ default:
+ // fall through to the exception at the end of the method
+ break;
}
}
else if (testFirst instanceof StringValueExp)
@@ -115,8 +116,9 @@
case Query.EQ:
return ((StringValueExp)testFirst).toString().compareTo(
((StringValueExp)testSecond).toString()) == 0;
+ default:
+ throw new BadStringOperationException("TODO");
}
- throw new BadStringOperationException("TODO");
}
else if (testFirst instanceof SingleValueExpSupport)
{
@@ -125,6 +127,9 @@
case Query.EQ:
return ((SingleValueExpSupport)testFirst).getValue().equals(
((SingleValueExpSupport)testSecond).getValue());
+ default:
+ // fall through to the exception at the end of the method
+ break;
}
}
// Review What happens now?
@@ -158,11 +163,4 @@
return buffer.toString();
}
- // Protected ---------------------------------------------------
-
- // Package Private ---------------------------------------------
-
- // Private -----------------------------------------------------
-
- // Inner Classes -----------------------------------------------
}
1.5 +1 -3 jmx/src/main/javax/management/BinaryOpValueExp.java
Index: BinaryOpValueExp.java
===================================================================
RCS file: /cvsroot/jboss/jmx/src/main/javax/management/BinaryOpValueExp.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- BinaryOpValueExp.java 24 Mar 2002 13:12:11 -0000 1.4
+++ BinaryOpValueExp.java 30 Sep 2002 15:16:23 -0000 1.5
@@ -20,12 +20,11 @@
* </ul>
*
* @author <a href="mailto:Adrian.Brock@HappeningTimes.com">Adrian Brock</a>.
- * @version $Revision: 1.4 $
+ * @version $Revision: 1.5 $
*/
/*package*/ class BinaryOpValueExp
extends ValueExpSupport
{
- // Constants ---------------------------------------------------
// Attributes --------------------------------------------------
@@ -44,7 +43,6 @@
*/
ValueExp second;
- // Static -----------------------------------------------------
// Constructors ------------------------------------------------
1.3 +1 -2 jmx/src/main/javax/management/FinalSubStringQueryExp.java
Index: FinalSubStringQueryExp.java
===================================================================
RCS file: /cvsroot/jboss/jmx/src/main/javax/management/FinalSubStringQueryExp.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- FinalSubStringQueryExp.java 24 Mar 2002 13:12:11 -0000 1.2
+++ FinalSubStringQueryExp.java 30 Sep 2002 15:16:23 -0000 1.3
@@ -6,7 +6,6 @@
*/
package javax.management;
-import java.io.Serializable;
/**
* A Final Substring Query Expression.<p>
@@ -19,7 +18,7 @@
* </ul>
*
* @author <a href="mailto:Adrian.Brock@HappeningTimes.com">Adrian Brock</a>.
- * @version $Revision: 1.2 $
+ * @version $Revision: 1.3 $
*/
/*package*/ class FinalSubStringQueryExp
extends QueryExpSupport
1.4 +1 -2 jmx/src/main/javax/management/InQueryExp.java
Index: InQueryExp.java
===================================================================
RCS file: /cvsroot/jboss/jmx/src/main/javax/management/InQueryExp.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- InQueryExp.java 24 Mar 2002 13:12:11 -0000 1.3
+++ InQueryExp.java 30 Sep 2002 15:16:23 -0000 1.4
@@ -6,7 +6,6 @@
*/
package javax.management;
-import java.io.Serializable;
/**
* An In Query Expression.<p>
@@ -26,7 +25,7 @@
* </ul>
*
* @author <a href="mailto:Adrian.Brock@HappeningTimes.com">Adrian Brock</a>.
- * @version $Revision: 1.3 $
+ * @version $Revision: 1.4 $
*/
/*package*/ class InQueryExp
extends QueryExpSupport
1.3 +1 -2 jmx/src/main/javax/management/InitialSubStringQueryExp.java
Index: InitialSubStringQueryExp.java
===================================================================
RCS file: /cvsroot/jboss/jmx/src/main/javax/management/InitialSubStringQueryExp.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- InitialSubStringQueryExp.java 24 Mar 2002 13:12:11 -0000 1.2
+++ InitialSubStringQueryExp.java 30 Sep 2002 15:16:23 -0000 1.3
@@ -6,7 +6,6 @@
*/
package javax.management;
-import java.io.Serializable;
/**
* An Initial Substring Query Expression.<p>
@@ -20,7 +19,7 @@
* </ul>
*
* @author <a href="mailto:Adrian.Brock@HappeningTimes.com">Adrian Brock</a>.
- * @version $Revision: 1.2 $
+ * @version $Revision: 1.3 $
*/
/*package*/ class InitialSubStringQueryExp
extends QueryExpSupport
1.6 +1 -2 jmx/src/main/javax/management/MBeanException.java
Index: MBeanException.java
===================================================================
RCS file: /cvsroot/jboss/jmx/src/main/javax/management/MBeanException.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- MBeanException.java 17 Aug 2002 15:48:28 -0000 1.5
+++ MBeanException.java 30 Sep 2002 15:16:23 -0000 1.6
@@ -7,14 +7,13 @@
package javax.management;
import java.io.PrintStream;
-import java.io.PrintWriter;
/**
* A wrapper for exceptions thrown by MBeans.
*
* @author <a href="mailto:juha@jboss.org">Juha Lindfors</a>
* @author <a href="mailto:Adrian.Brock@HappeningTimes.com">Adrian Brock</a>
- * @version $Revision: 1.5 $
+ * @version $Revision: 1.6 $
*
* <p><b>Revisions:</b>
*
1.5 +1 -2 jmx/src/main/javax/management/MBeanServerFactory.java
Index: MBeanServerFactory.java
===================================================================
RCS file: /cvsroot/jboss/jmx/src/main/javax/management/MBeanServerFactory.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- MBeanServerFactory.java 3 Feb 2002 23:21:05 -0000 1.4
+++ MBeanServerFactory.java 30 Sep 2002 15:16:23 -0000 1.5
@@ -7,7 +7,6 @@
package javax.management;
import java.util.Map;
-import java.util.List;
import java.util.HashMap;
import java.util.ArrayList;
@@ -22,7 +21,7 @@
* @see javax.management.MBeanServer
*
* @author <a href="mailto:juha@jboss.org">Juha Lindfors</a>.
- * @version $Revision: 1.4 $
+ * @version $Revision: 1.5 $
*
*/
public class MBeanServerFactory
1.5 +2 -3 jmx/src/main/javax/management/MatchQueryExp.java
Index: MatchQueryExp.java
===================================================================
RCS file: /cvsroot/jboss/jmx/src/main/javax/management/MatchQueryExp.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- MatchQueryExp.java 24 Mar 2002 13:12:11 -0000 1.4
+++ MatchQueryExp.java 30 Sep 2002 15:16:23 -0000 1.5
@@ -24,7 +24,7 @@
* </ul>
*
* @author <a href="mailto:Adrian.Brock@HappeningTimes.com">Adrian Brock</a>.
- * @version $Revision: 1.4 $
+ * @version $Revision: 1.5 $
*/
/*package*/ class MatchQueryExp
extends QueryExpSupport
@@ -111,7 +111,7 @@
}
}
// REVIEW: Should this be an error?
- if (escaping == true)
+ if (escaping)
buffer.append("\\\\");
re = new UncheckedRE(buffer);
@@ -128,7 +128,6 @@
InvalidApplicationException
{
ValueExp calcAttr = attr.apply(name);
- ValueExp calcString = string.apply(name);
if (calcAttr instanceof StringValueExp)
{
1.4 +1 -2 jmx/src/main/javax/management/NotQueryExp.java
Index: NotQueryExp.java
===================================================================
RCS file: /cvsroot/jboss/jmx/src/main/javax/management/NotQueryExp.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- NotQueryExp.java 24 Mar 2002 13:12:12 -0000 1.3
+++ NotQueryExp.java 30 Sep 2002 15:16:23 -0000 1.4
@@ -6,7 +6,6 @@
*/
package javax.management;
-import java.io.Serializable;
/**
* A NOT Query Expression.<p>
@@ -24,7 +23,7 @@
* </ul>
*
* @author <a href="mailto:Adrian.Brock@HappeningTimes.com">Adrian Brock</a>.
- * @version $Revision: 1.3 $
+ * @version $Revision: 1.4 $
*/
/*package*/ class NotQueryExp
extends QueryExpSupport
1.4 +1 -17 jmx/src/main/javax/management/NumberValueExp.java
Index: NumberValueExp.java
===================================================================
RCS file: /cvsroot/jboss/jmx/src/main/javax/management/NumberValueExp.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- NumberValueExp.java 24 Mar 2002 13:12:12 -0000 1.3
+++ NumberValueExp.java 30 Sep 2002 15:16:23 -0000 1.4
@@ -10,16 +10,11 @@
* A Number that is an arguement to a query.<p>
*
* @author <a href="mailto:Adrian.Brock@HappeningTimes.com">Adrian Brock</a>.
- * @version $Revision: 1.3 $
+ * @version $Revision: 1.4 $
*/
/*package*/ class NumberValueExp
extends SingleValueExpSupport
{
- // Constants ---------------------------------------------------
-
- // Attributes --------------------------------------------------
-
- // Static -----------------------------------------------------
// Constructors ------------------------------------------------
@@ -60,15 +55,4 @@
return ((Number)getValue()).doubleValue();
}
- // X Implementation --------------------------------------------
-
- // Y overrides -------------------------------------------------
-
- // Protected ---------------------------------------------------
-
- // Package Private ---------------------------------------------
-
- // Private -----------------------------------------------------
-
- // Inner Classes -----------------------------------------------
}
1.4 +1 -10 jmx/src/main/javax/management/OrQueryExp.java
Index: OrQueryExp.java
===================================================================
RCS file: /cvsroot/jboss/jmx/src/main/javax/management/OrQueryExp.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- OrQueryExp.java 24 Mar 2002 13:12:12 -0000 1.3
+++ OrQueryExp.java 30 Sep 2002 15:16:23 -0000 1.4
@@ -6,7 +6,6 @@
*/
package javax.management;
-import java.io.Serializable;
/**
* An OR Query Expression.<p>
@@ -24,12 +23,11 @@
* </ul>
*
* @author <a href="mailto:Adrian.Brock@HappeningTimes.com">Adrian Brock</a>.
- * @version $Revision: 1.3 $
+ * @version $Revision: 1.4 $
*/
/*package*/ class OrQueryExp
extends QueryExpSupport
{
- // Constants ---------------------------------------------------
// Attributes --------------------------------------------------
@@ -43,11 +41,9 @@
*/
QueryExp second;
- // Static ------------------------------------------------------
// Constructors ------------------------------------------------
-
/**
* Create a new OR query Expression
*
@@ -80,9 +76,4 @@
return new String("(" + first.toString() + ") || (" + second.toString()) + ")";
}
- // Protected ---------------------------------------------------
-
- // Private -----------------------------------------------------
-
- // Inner classes -----------------------------------------------
}
1.3 +1 -18 jmx/src/main/javax/management/QueryExpSupport.java
Index: QueryExpSupport.java
===================================================================
RCS file: /cvsroot/jboss/jmx/src/main/javax/management/QueryExpSupport.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- QueryExpSupport.java 24 Mar 2002 13:12:12 -0000 1.2
+++ QueryExpSupport.java 30 Sep 2002 15:16:23 -0000 1.3
@@ -6,7 +6,6 @@
*/
package javax.management;
-import java.io.Serializable;
/**
* An implementation of Query expression. Apply always returns false.
@@ -18,18 +17,11 @@
* </ul>
*
* @author <a href="mailto:Adrian.Brock@HappeningTimes.com">Adrian Brock</a>.
- * @version $Revision: 1.2 $
+ * @version $Revision: 1.3 $
*/
/*package*/ class QueryExpSupport
implements QueryExp
{
- // Constants ---------------------------------------------------
-
- // Attributes --------------------------------------------------
-
- // Static ------------------------------------------------------
-
- // Public ------------------------------------------------------
// QueryExp implementation -------------------------------------
@@ -47,13 +39,4 @@
QueryEval.server.set(server);
}
- // X overides --------------------------------------------------
-
- // Protected ---------------------------------------------------
-
- // Package Private ---------------------------------------------
-
- // Private -----------------------------------------------------
-
- // Inner classes -----------------------------------------------
}
1.2 +1 -2 jmx/src/main/javax/management/SingleValueExpSupport.java
Index: SingleValueExpSupport.java
===================================================================
RCS file: /cvsroot/jboss/jmx/src/main/javax/management/SingleValueExpSupport.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- SingleValueExpSupport.java 17 Feb 2002 12:41:52 -0000 1.1
+++ SingleValueExpSupport.java 30 Sep 2002 15:16:23 -0000 1.2
@@ -6,13 +6,12 @@
*/
package javax.management;
-import java.io.Serializable;
/**
* An implementation of single value expression.
*
* @author <a href="mailto:Adrian.Brock@HappeningTimes.com">Adrian Brock</a>.
- * @version $Revision: 1.1 $
+ * @version $Revision: 1.2 $
*/
/*package*/ class SingleValueExpSupport
extends ValueExpSupport
1.4 +1 -15 jmx/src/main/javax/management/ValueExpSupport.java
Index: ValueExpSupport.java
===================================================================
RCS file: /cvsroot/jboss/jmx/src/main/javax/management/ValueExpSupport.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- ValueExpSupport.java 17 Aug 2002 15:48:28 -0000 1.3
+++ ValueExpSupport.java 30 Sep 2002 15:16:23 -0000 1.4
@@ -6,7 +6,6 @@
*/
package javax.management;
-import java.io.Serializable;
/**
* An implementation of Value expression. Apply always returns this.
@@ -18,7 +17,7 @@
* </ul>
*
* @author <a href="mailto:Adrian.Brock@HappeningTimes.com">Adrian Brock</a>.
- * @version $Revision: 1.3 $
+ * @version $Revision: 1.4 $
*/
/*package*/ class ValueExpSupport
implements ValueExp
@@ -27,13 +26,6 @@
private static final long serialVersionUID = 5668002406025575052L;
- // Attributes --------------------------------------------------
-
- // Static ------------------------------------------------------
-
- // Constructor -------------------------------------------------
-
- // Public ------------------------------------------------------
// ValueExp implementation -------------------------------------
@@ -51,9 +43,6 @@
QueryEval.server.set(server);
}
- // Object overrides --------------------------------------------
-
- // Protected ---------------------------------------------------
// Package -----------------------------------------------------
@@ -65,7 +54,4 @@
return (MBeanServer) QueryEval.server.get();
}
- // Private -----------------------------------------------------
-
- // Inner classes -----------------------------------------------
}
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
jboss-cvs-commits mailing list
jboss-cvs-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jboss-cvs-commits
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic