[prev in list] [next in list] [prev in thread] [next in thread] 

List:       java-apache-framework
Subject:    Re: Pool bug ?
From:       "Luca Masini" <l.masini () infogroup ! it>
Date:       2001-01-31 15:06:42
[Download RAW message or body]

That's fine !!!

----- Original Message ----- 
From: "Peter Donald" <donaldp@apache.org>
To: "Java Apache Framework" <java-apache-framework@list.working-dogs.com>
Sent: Wednesday, 31 January, 2001 2:46 PM
Subject: Re: Pool bug ?


> At 11:48  31/1/01 +0100, you wrote:
> >In order to mantai backward compatibility, I had to change AbstractPool
> constructor:
> >
> > public AbstractPool( final ObjectFactory factory,
> >       final PoolController controller,
> >       final int initial,
> >       final int maximum ) throws Exception 
> > {
> >  m_count = 0;
> >  m_factory = factory;
> >  m_controller = controller;
> >  m_maximum = maximum;
> >  m_initial = initial;
> >
> >  grow( maximum );
> >  fill( initial );
> >
> > }
> >
> >As you can easily see, I added grow and fill in the end of the method. Was
> this a design decision or a oversite ?
> 
> It was a pseudo design decision. We should offer two different constructors
> I guess. The reaosn for this change was that in constructor the pool object
> wasn't fully constructed. Some pools need to manipulate the pooled objects
> as they are created but can only do this aftered initialized - hence the
> change.
> 
> I will put back in another constructor that allows you to fill it by
> default I think - thoughts ?
> 
> 
> Cheers,
> 
> Pete
> 
> *-----------------------------------------------------*
> | "Faced with the choice between changing one's mind, |
> | and proving that there is no need to do so - almost |
> | everyone gets busy on the proof."                   |
> |              - John Kenneth Galbraith               |
> *-----------------------------------------------------*
> 
> 
> 
> ------------------------------------------------------------
> To subscribe:    java-apache-framework-on@list.working-dogs.com
> To unsubscribe:  java-apache-framework-off@list.working-dogs.com
> Problems?:       jon@working-dogs.com



------------------------------------------------------------
To subscribe:    java-apache-framework-on@list.working-dogs.com
To unsubscribe:  java-apache-framework-off@list.working-dogs.com
Problems?:       jon@working-dogs.com

[prev in list] [next in list] [prev in thread] [next in thread]