[prev in list] [next in list] [prev in thread] [next in thread] 

List:       james-dev
Subject:    [PATCH] SenderIs/RecipientIs
From:       "Noel J. Bergman" <noel () devtech ! com>
Date:       2002-09-29 3:20:03
[Download RAW message or body]

These two are almost identical, but one had been updated.  Now they are
closer.

RecipientIs changes are primarily cosmetic.  The data member is changed to a
Collection, which is all that the contract requires, instead of a Set.  The
fully qualified class name is used in the one place it is reference, rather
than an import, because it is easier to change it from one type of
Collection to another that way (change one line instead of two).

SenderIs picks up the changes made earlier by Serge to RecipientIs:

    HashSet replaces Vector
    MailAddress objects are instantiated instead of Strings

Based upon Peter's recent change to NotifySender/NotifyPostmaster, perhaps
neither one of these matchers should use MailAddress?  I made SenderIs to
match RecipientIs, both of which now parse the addresses for validity, which
means that the config is checked at init time, but do we want to support
matching "addresses" that are not valid?  If so, then both matchers need to
revert to String.

	--- Noel

["james-diffs" (application/octet-stream)]

--
To unsubscribe, e-mail:   <mailto:james-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:james-dev-help@jakarta.apache.org>

[prev in list] [next in list] [prev in thread] [next in thread]