[prev in list] [next in list] [prev in thread] [next in thread]
List: james-dev
Subject: Re: Small Patch
From: "Serge Knystautas" <sergek () lokitech ! com>
Date: 2001-09-29 5:06:30
[Download RAW message or body]
Patched. Thanks.
Serge Knystautas
Loki Technologies
http://www.lokitech.com/
----- Original Message -----
From: Matthew Pangaro
To: james-dev@jakarta.apache.org
Sent: Friday, September 28, 2001 6:46 PM
Subject: Re: Small Patch
Ok,
Here's a new version of the patch I just sent, which should be a bit cleaner. The \
diff is now just to patch MailAddress. The original change is still there, but now \
it's changed the getHost() method to return the ip address without the [] chars, in \
the case of a dotNum host. It seemed like this was better, since it should avoid \
having to patch any other classes. I don't think there are any other classes where \
the MailAddress is being deconstructed and reconstructed. That's the only thing this \
would affect, since the new email address string would lack the braces.
Matt Pangaro
p.s. Sorry for the extraneous traffic.
p.p.s. the "objectionable" content in the diff and the original message have been \
cleansed to protect the innocent and the pure of heart... ;-)
----- Original Message -----
From: Matthew Pangaro
To: james-dev@jakarta.apache.org
Sent: Friday, September 28, 2001 5:45 PM
Subject: Small Patch
Hi all,
Was looking in Bugzilla to see if there was anything I could take a stab at. \
Attached is a diff for bug 2006. This should get MailAddress to accept \
localpart@[yyy.yyy.yyy.yyy] addresses.
diff.txt patches MailAddress to make it properly parse out the dotNum host part. \
diff2.txt is a patch to RemoteDelivery to have it strip the [] chars from the host \
before doing getMailServers, so the lookup works.
If the fixes are acceptable, I'm not sure what the protocol is, but the bug could \
be closed in bugzilla.
Have done some local testing, and will keep hacking at it to see if there are any \
other parts choking on the [yyy.yyy.yyy.yyy] host parts.
------------------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: james-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: james-dev-help@jakarta.apache.org
[Attachment #3 (text/html)]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=Content-Type content="text/html; charset=iso-8859-1">
<META content="MSHTML 5.50.4616.200" name=GENERATOR>
<STYLE></STYLE>
</HEAD>
<BODY bgColor=#ffffff>
<DIV><FONT face=Arial size=2>Patched. Thanks.</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>Serge Knystautas</FONT></DIV>
<DIV><FONT face=Arial size=2>Loki Technologies</FONT></DIV>
<DIV><FONT face=Arial size=2><A
href="http://www.lokitech.com/">http://www.lokitech.com/</A></FONT></DIV>
<BLOCKQUOTE
style="PADDING-RIGHT: 0px; PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: #000000 \
2px solid; MARGIN-RIGHT: 0px"> <DIV style="FONT: 10pt arial">----- Original Message \
----- </DIV> <DIV
style="BACKGROUND: #e4e4e4; FONT: 10pt arial; font-color: black"><B>From:</B>
<A title=mpangaro@lokitech.com href="mailto:mpangaro@lokitech.com">Matthew
Pangaro</A> </DIV>
<DIV style="FONT: 10pt arial"><B>To:</B> <A title=james-dev@jakarta.apache.org
href="mailto:james-dev@jakarta.apache.org">james-dev@jakarta.apache.org</A>
</DIV>
<DIV style="FONT: 10pt arial"><B>Sent:</B> Friday, September 28, 2001 6:46
PM</DIV>
<DIV style="FONT: 10pt arial"><B>Subject:</B> Re: Small Patch</DIV>
<DIV><BR></DIV>
<DIV><FONT face=Arial size=2>Ok,</FONT></DIV>
<DIV><FONT face=Arial size=2>Here's a new version of the patch I just sent,
which should be a bit cleaner. The diff is now just to patch MailAddress. The
original change is still there, but now it's changed the getHost() method to
return the ip address without the [] chars, in the case of a dotNum host. It
seemed like this was better, since it should avoid having to patch any other
classes. I don't think there are any other classes where the MailAddress is
being deconstructed and reconstructed. That's the only thing this would
affect, since the new email address string would lack the braces.</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>Matt Pangaro</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>p.s. Sorry for the extraneous
traffic.</FONT></DIV>
<DIV><FONT face=Arial size=2>p.p.s. the "objectionable" content in the diff
and the original message have been cleansed to protect the innocent and the
pure of heart... ;-)</FONT></DIV>
<BLOCKQUOTE dir=ltr
style="PADDING-RIGHT: 0px; PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: \
#000000 2px solid; MARGIN-RIGHT: 0px"> <DIV style="FONT: 10pt arial">----- Original \
Message ----- </DIV> <DIV
style="BACKGROUND: #e4e4e4; FONT: 10pt arial; font-color: black"><B>From:</B>
<A title=mpangaro@lokitech.com href="mailto:mpangaro@lokitech.com">Matthew
Pangaro</A> </DIV>
<DIV style="FONT: 10pt arial"><B>To:</B> <A
title=james-dev@jakarta.apache.org
href="mailto:james-dev@jakarta.apache.org">james-dev@jakarta.apache.org</A>
</DIV>
<DIV style="FONT: 10pt arial"><B>Sent:</B> Friday, September 28, 2001 5:45
PM</DIV>
<DIV style="FONT: 10pt arial"><B>Subject:</B> Small Patch</DIV>
<DIV><FONT face=Arial size=2></FONT><FONT face=Arial
size=2></FONT><BR></DIV>
<DIV><FONT face=Arial size=2>Hi all,</FONT></DIV>
<DIV><FONT face=Arial size=2>Was looking in Bugzilla to see if there was
anything I could take a stab at. Attached is a diff for bug 2006. This
should get MailAddress to accept <A
href="mailto:localpart@[yyy.yyy.yyy.yyy">localpart@[yyy.yyy.yyy.yyy</A>]
addresses.</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>diff.txt patches MailAddress to make it
properly parse out the dotNum host part. diff2.txt is a patch to
RemoteDelivery to have it strip the [] chars from the host before doing
getMailServers, so the lookup works.</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>If the fixes are acceptable, I'm not sure
what the protocol is, but the bug could be closed in bugzilla.</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>Have done some local testing, and will keep
hacking at it to see if there are any other parts choking on the [<U><FONT
color=#0000ff>yyy.yyy.yyy.yyy</FONT></U>] host parts.</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV></BLOCKQUOTE>
<P>
<HR>
<P></P>---------------------------------------------------------------------<BR>To
unsubscribe, e-mail: james-dev-unsubscribe@jakarta.apache.org<BR>For
additional commands, e-mail:
james-dev-help@jakarta.apache.org</BLOCKQUOTE></BODY></HTML>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic