[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    =?utf-8?q?Re=3A_=5BPR=5D_Cleanup_help_formatting_=5Bcommons-cli=5D?=
From:       garydgregory_(via_GitHub) <git () apache ! org>
Date:       2024-05-18 17:06:44
Message-ID: PR_kwDOAAM9d85v2k1n-fcdfbbb3-50b9-406f-bf79-9abb0289b5bb () gitbox ! apache ! org
[Download RAW message or body]


garydgregory commented on code in PR #277:
URL: https://github.com/apache/commons-cli/pull/277#discussion_r1605818691


##########
src/main/java/org/apache/commons/cli/HelpFormatter.java:
##########
@@ -129,6 +129,16 @@ public Builder setShowDeprecated(final boolean useDefaultFormat) \
{  }
     }
 
+    /**
+     * Gets the option description or an empty string if the description is {@code \
null}. +     * @param option The option to get the description from.
+     * @return the option description or an empty string if the description is \
{@code null}. +     * @since 2.17.0

Review Comment:
   The next version should be 1.8.0, not 2.17.0.
   Also, the new public method (if indeed it should be public, should it?) needs its \
own `@Test` method (IMO).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]