[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    (commons-configuration) branch master updated: Replace Locale.ENGLISH with Locale.ROOT in tests
From:       ggregory () apache ! org
Date:       2024-04-30 22:22:20
Message-ID: 171451574054.2558218.16764589988715779173 () gitbox2-he-fi ! apache ! org
[Download RAW message or body]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-configuration.git


The following commit(s) were added to refs/heads/master by this push:
     new fd036108 Replace Locale.ENGLISH with Locale.ROOT in tests
fd036108 is described below

commit fd036108e282e414fe215cad619c74426a59d750
Author: Gary Gregory <garydgregory@gmail.com>
AuthorDate: Tue Apr 30 18:22:16 2024 -0400

    Replace Locale.ENGLISH with Locale.ROOT in tests
---
 .../combined/TestFileExtensionConfigurationBuilderProvider.java       | 2 +-
 .../org/apache/commons/configuration2/tree/TestNodeNameMatchers.java  | 4 ++--
 .../configuration2/tree/xpath/TestConfigurationAttributePointer.java  | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/test/java/org/apache/commons/configuration2/builder/combined/TestFileExtensionConfigurationBuilderProvider.java \
b/src/test/java/org/apache/commons/configuration2/builder/combined/TestFileExtensionConfigurationBuilderProvider.java
 index 15c5b92e..e309cfa4 100644
--- a/src/test/java/org/apache/commons/configuration2/builder/combined/TestFileExtensionConfigurationBuilderProvider.java
                
+++ b/src/test/java/org/apache/commons/configuration2/builder/combined/TestFileExtensionConfigurationBuilderProvider.java
 @@ -92,7 +92,7 @@ public class TestFileExtensionConfigurationBuilderProvider {
     @Test
     public void testDetermineConfigurationClassMatchCase() throws \
ConfigurationException {  final ConfigurationDeclaration decl = setUpDecl();
-        final BuilderParameters params = new \
FileBasedBuilderParametersImpl().setPath("C:\\Test\\someTestConfiguration." + \
EXT.toUpperCase(Locale.ENGLISH)); +        final BuilderParameters params = new \
FileBasedBuilderParametersImpl().setPath("C:\\Test\\someTestConfiguration." + \
                EXT.toUpperCase(Locale.ROOT));
         final FileExtensionConfigurationBuilderProvider provider = setUpProvider();
         assertEquals(MATCH_CLASS, provider.determineConfigurationClass(decl, \
Collections.singleton(params)));  }
diff --git a/src/test/java/org/apache/commons/configuration2/tree/TestNodeNameMatchers.java \
b/src/test/java/org/apache/commons/configuration2/tree/TestNodeNameMatchers.java \
                index d418205f..5fcc56d9 100644
--- a/src/test/java/org/apache/commons/configuration2/tree/TestNodeNameMatchers.java
+++ b/src/test/java/org/apache/commons/configuration2/tree/TestNodeNameMatchers.java
@@ -67,8 +67,8 @@ public class TestNodeNameMatchers {
     public void testEqualsIgnoreCaseMatch() {
         final ImmutableNode node = createNode(NODE_NAME);
         assertTrue(NodeNameMatchers.EQUALS_IGNORE_CASE.matches(node, handler, \
                NODE_NAME));
-        assertTrue(NodeNameMatchers.EQUALS_IGNORE_CASE.matches(node, handler, \
                NODE_NAME.toLowerCase(Locale.ENGLISH)));
-        assertTrue(NodeNameMatchers.EQUALS_IGNORE_CASE.matches(node, handler, \
NODE_NAME.toUpperCase(Locale.ENGLISH))); +        \
assertTrue(NodeNameMatchers.EQUALS_IGNORE_CASE.matches(node, handler, \
NODE_NAME.toLowerCase(Locale.ROOT))); +        \
assertTrue(NodeNameMatchers.EQUALS_IGNORE_CASE.matches(node, handler, \
NODE_NAME.toUpperCase(Locale.ROOT)));  }
 
     /**
diff --git a/src/test/java/org/apache/commons/configuration2/tree/xpath/TestConfigurationAttributePointer.java \
b/src/test/java/org/apache/commons/configuration2/tree/xpath/TestConfigurationAttributePointer.java
 index c8badaeb..e68f7fe2 100644
--- a/src/test/java/org/apache/commons/configuration2/tree/xpath/TestConfigurationAttributePointer.java
                
+++ b/src/test/java/org/apache/commons/configuration2/tree/xpath/TestConfigurationAttributePointer.java
 @@ -57,7 +57,7 @@ public class TestConfigurationAttributePointer {
         final ImmutableNode.Builder ndBuilder = new ImmutableNode.Builder();
         ndBuilder.name("parent").addAttribute(ATTR_NAME, ATTR_VALUE);
         final ImmutableNode nd = ndBuilder.create();
-        parent = new ConfigurationNodePointer<>(nd, Locale.ENGLISH, new \
InMemoryNodeModel(nd).getNodeHandler()); +        parent = new \
ConfigurationNodePointer<>(nd, Locale.ROOT, new \
InMemoryNodeModel(nd).getNodeHandler());  pointer = new \
ConfigurationAttributePointer<>(parent, ATTR_NAME);  }
 


[prev in list] [next in list] [prev in thread] [next in thread]