'Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC2'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC2
From:       Bruno Kinoshita <kinow () apache ! org>
Date:       2023-01-31 21:07:42
Message-ID: CANNuEs1dj=9RaPLcrMaK7otsk5JsqY11BPTnsyjo35TAkCstFA () mail ! gmail ! com
[Download RAW message or body]


That's odd. I ran the same command now on my checked out tag and got no
warnings, Arturo.

[INFO] --- apache-rat-plugin:0.15:check (default-cli) @ commons-csv ---
[INFO] Enabled default license matchers.
[INFO] Will parse SCM ignores for exclusions...
[INFO] Parsing exclusions from
/home/kinow/Development/java/apache/commons-csv/.gitignore
[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 74 implicit excludes.
[INFO] 34 explicit excludes.
[INFO] 83 resources included
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0,
generated: 0, approved: 76 licenses.
[INFO]

The files you have in the warning exist.

kinow@ranma:~/Development/java/apache/commons-csv$ file
src/test/resources/org/apache/commons/csv/empty.txt
src/test/resources/org/apache/commons/csv/empty.txt: empty

Any chance you have a copy of commons-csv-rc2 inside another commons-csv
folder?

Cheers
Bruno


On Tue, 31 Jan 2023 at 21:43, Arturo Bernal <arturobernalg@yahoo.com.invalid>
wrote:

> Hi Gary,
> 
> If you run the default maven goal (clean verify apache-rat:check
> japicmp:cmp checkstyle:check spotbugs:check pmd:check pmd:cpd-check
> javadoc:javadoc) wich contain apache-rat:check, the output will be
> something like that
> 
> [WARNING] Files with unapproved licenses:
> 
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/empty.txt
> 
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSV-259/sample.txt
> 
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/csv-167/sample1.csv
>  
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSV-141/csv-141.csv
>  
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/testCSV85_ignoreEmpty.txt
>  
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/test_default_comment.txt
>  
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/bom.csv
>  
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/testCSV246.csv
>  
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/test.csv
>  
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/test_rfc4180.txt
>  
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/testCSV246_checkWithNoComment.txt
>  
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/testCSV85.csv
>  
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/test_rfc4180_trim.txt
>  
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/test_default.txt
>  
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/testCSV85_default.txt
>  
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSV-290/psql.tsv
> 
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSV-290/psql.csv
> 
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSV-213/999751170.patch.csv
>  
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSV-198/optd_por_public.csv
>  commons-csv-1.10.0-RC2/src/site/resources/profile.jacoco
> commons-csv-1.10.0-RC2/src/site/resources/download_csv.cgi
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time:  3.733 s
> [INFO] Finished at: 2023-01-31T21:39:45+01:00
> 
> 
> Arturo Bernal
> arturobernalg@yahoo.com
> 
> 
> 
> > On 28 Jan 2023, at 22:44, Gary Gregory <garydgregory@gmail.com> wrote:
> > 
> > Arturo,
> > 
> > Thank you for your review.
> > 
> > "The only thing the rat error. Someone should  to tackle that"
> > 
> > Please be specific.
> > 
> > Gary
> > 
> > On Sat, Jan 28, 2023, 16:02 Arturo Bernal <arturobernalg@yahoo.com
> .invalid>
> > wrote:
> > 
> > > [+1
> > > 
> > > > Built from tag with `mvn clean test install site` with no issues, on
> > > 
> > > Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
> > > Maven home: /opt/apache-maven-3.8.1
> > > Java version: 17.0.2, vendor: Oracle Corporation, runtime:
> > > /Library/Java/JavaVirtualMachines/jdk-17.0.2.jdk/Contents/Home
> > > Default locale: en_US, platform encoding: UTF-8
> > > OS name: "mac os x", version: "13.1", arch: "x86_64", family: "mac"
> > > ]
> > > 
> > > The only thing the rat error. Someone should  to tackle that
> > > 
> > > 
> > > Arturo Bernal
> > > arturobernalg@yahoo.com
> > > 
> > > 
> > > 
> > > > On 28 Jan 2023, at 21:45, Bruno Kinoshita <kinow@apache.org> wrote:
> > > > 
> > > > [x] +1 Release these artifacts
> > > > 
> > > > Built from tag with `mvn clean test install site` with no issues, on
> > > > 
> > > > Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
> > > > Maven home: /opt/apache-maven-3.8.5
> > > > Java version: 17.0.5, vendor: Private Build, runtime:
> > > > /usr/lib/jvm/java-17-openjdk-amd64
> > > > Default locale: en_US, platform encoding: UTF-8
> > > > OS name: "linux", version: "5.15.0-58-generic", arch: "amd64", family:
> > > > "unix"
> > > > 
> > > > 
> > > > Site reports look really good.
> > > > 
> > > > Inspected some dist files, found no issues.
> > > > 
> > > > Checked signatures of dist area files, found no issues.
> > > > 
> > > > Thanks!
> > > > Bruno
> > > > 
> > > > On Sat, 28 Jan 2023 at 19:03, Gary Gregory <garydgregory@gmail.com>
> > > wrote:
> > > > 
> > > > > We have fixed quite a few bugs and added some enhancements since
> > > > > Apache Commons CSV 1.9.0 was released, so I would like to release
> > > > > Apache Commons CSV 1.10.0.
> > > > > 
> > > > > Apache Commons CSV 1.10.0 RC2 is available for review here:
> > > > > https://dist.apache.org/repos/dist/dev/commons/csv/1.10.0-RC2 (svn
> > > > > revision 59641)
> > > > > 
> > > > > The Git tag commons-csv-1.10.0-RC2 commit for this RC is
> > > > > 5b99c860986a87f9da664bf47a3a7c0026673123 which you can browse here:
> > > > > 
> > > > > 
> > > 
> https://gitbox.apache.org/repos/asf?p=commons-csv.git;a=commit;h=5b99c860986a87f9da664bf47a3a7c0026673123
> 
> > > > > You may checkout this tag using:
> > > > > git clone https://gitbox.apache.org/repos/asf/commons-csv.git
> > > > > --branch <https://gitbox.apache.org/repos/asf/commons-csv.git--branch
> > 
> > > > > commons-csv-1.10.0-RC2 commons-csv-1.10.0-RC2
> > > > > 
> > > > > Maven artifacts are here:
> > > > > 
> > > > > 
> > > 
> https://repository.apache.org/content/repositories/orgapachecommons-1617/org/apache/commons/commons-csv/1.10.0/
> 
> > > > > 
> > > > > These are the artifacts and their hashes:
> > > > > 
> > > > > #Release SHA-512s
> > > > > #Sat Jan 28 12:52:21 EST 2023
> > > > > 
> > > > > 
> > > 
> commons-csv-1.10.0-bin.tar.gz=889e25045a1491253b02fac788a6357e6ce4e8285d420cf60872ad7fe09fa3b15799d17b1a9c9cff503aaecaa4952490e2bcef581872117d4d1e2347f765ff42
> 
> > > > > 
> > > > > 
> > > 
> commons-csv-1.10.0-bin.zip=c179c3efd1f6e5aa562a17d17c26b2662d48823778a7232bce32e17808ae3d33268602349e40ff3578b65b1d74dc7a065d5e8d104a05092c15573f245fcadfef
> 
> > > > > 
> > > > > 
> > > 
> commons-csv-1.10.0-bom.json=aeb13ce03a3712f6313b389b25a8d65624679d9d31edf7b9a49618c1462da3170148155b2688e11b8d2df6ea09e68bea47a9635158765ca02c8c33749c9777e8
> 
> > > > > 
> > > > > 
> > > 
> commons-csv-1.10.0-bom.xml=8f7f5e75be14bca0e79747f99181dc289e39871863009da90071100ee7ef5dae17e0287e7da5542bce3f98917f605016fabaab4a42908ed7c4118963534cf2fa
> 
> > > > > 
> > > > > 
> > > 
> commons-csv-1.10.0-javadoc.jar=e1f238122b92a1bfb2e9845f55ef91c275d8c47624b6c6699d0c57a98db2470ae0a14bd3668972ac8bc11271404fe56799ec1536b3de49db218121d01ddb5f1d
> 
> > > > > 
> > > > > 
> > > 
> commons-csv-1.10.0-sources.jar=1d778c86c5c0218180a4dc8a02052cec7c1cba6f71ad8d4bdfa256c0133b5e1c8c06ac775ef914d9baf2278803ba3796646693be49119aac28c4a4457ba03ac0
> 
> > > > > 
> > > > > 
> > > 
> commons-csv-1.10.0-src.tar.gz=2674b0cc0806fbfc7013f759ef3c2149a73406809e9f1a84cea1ec12ae66514682ebec4f902d1385f5f6dcdf2b0babbaa289823722ce175804196d3b3b5427fb
> 
> > > > > 
> > > > > 
> > > 
> commons-csv-1.10.0-src.zip=0123ed2538214e767a264d4632bb4ab82367d8e4a4b4095722a3c821d2222646262af0634588a5e1025ef6e2b249a6d5e654cdbdba8d567272abcb7149f7adc5
> 
> > > > > 
> > > > > 
> > > 
> commons-csv-1.10.0-test-sources.jar=5f88b40f08923074384fe883214a3be19c42d07a73a753f2afbd99c66e2606aa9a4e619ed878183f0ca1bda4a35448be60d53cd27b3ad24bcac4f8ffff3e4b63
> 
> > > > > 
> > > > > 
> > > 
> commons-csv-1.10.0-tests.jar=f3475a56cff362167ff592113dff8fbc4792c1601b87a85cb1cb1560bc52bb49b540282b057e1cde21ddb06664dc8c591d87a475b2bf12ef205efd1860dd4048
> 
> > > > > 
> > > > > 
> > > 
> org.apache.commons_commons-csv-1.10.0.spdx.json=4609932f7a3bbb0158021d29ea1baaa163b8 \
> 4c06786b36a46eaaa81f096df3d7cbdd28a99b587f6cdf6fbd4bbe1a38e1f1f9eeab89847474a2f4056765b9be6d
> 
> > > > > 
> > > > > 
> > > > > I have tested this with 'mvn -V -Prelease -Ptest-deploy -P jacoco -P
> > > > > japicmp clean package site deploy' using:
> > > > > 
> > > > > Apache Maven 3.8.7 (b89d5959fcde851dcb1c8946a785a163f14e1e29)
> > > > > Maven home: /usr/local/Cellar/maven/3.8.7/libexec
> > > > > Java version: 1.8.0_362, vendor: Homebrew, runtime:
> > > > > /usr/local/Cellar/openjdk@8
> > > > > /1.8.0+362/libexec/openjdk.jdk/Contents/Home/jre
> > > > > Default locale: en_US, platform encoding: UTF-8
> > > > > OS name: "mac os x", version: "13.1", arch: "x86_64", family: "mac"
> > > > > 
> > > > > Darwin **** 22.2.0 Darwin Kernel Version 22.2.0: Fri Nov 11 02:08:47
> > > > > PST 2022; root:xnu-8792.61.2~4/RELEASE_X86_64 x86_64
> > > > > 
> > > > > Details of changes since 1.9.0 are in the release notes:
> > > > > 
> > > > > 
> > > 
> https://dist.apache.org/repos/dist/dev/commons/csv/1.10.0-RC2/RELEASE-NOTES.txt
> > > > > 
> > > > > 
> > > 
> https://dist.apache.org/repos/dist/dev/commons/csv/1.10.0-RC2/site/changes-report.html
> 
> > > > > 
> > > > > Site:
> > > > > 
> > > > > 
> > > 
> https://dist.apache.org/repos/dist/dev/commons/csv/1.10.0-RC2/site/index.html
> > > > > (note some *relative* links are broken and the 1.10.0 directories
> > > > > are not yet created - these will be OK once the site is deployed.)
> > > > > 
> > > > > JApiCmp Report (compared to 1.9.0):
> > > > > 
> > > > > 
> > > 
> https://dist.apache.org/repos/dist/dev/commons/csv/1.10.0-RC2/site/japicmp.html
> > > > > Where the following is intentional:
> > > > > MODIFIED (Serializable incompatible(!): serialVersionUID modified)
> > > > > final public class org.apache.commons.csv.CSVFormat
> > > > > 
> > > > > RAT Report:
> > > > > 
> > > > > 
> > > 
> https://dist.apache.org/repos/dist/dev/commons/csv/1.10.0-RC2/site/rat-report.html
> > > > > 
> > > > > KEYS:
> > > > > https://downloads.apache.org/commons/KEYS
> > > > > 
> > > > > Please review the release candidate and vote.
> > > > > This vote will close no sooner than 72 hours from now.
> > > > > 
> > > > > [ ] +1 Release these artifacts
> > > > > [ ] +0 OK, but...
> > > > > [ ] -0 OK, but really should fix...
> > > > > [ ] -1 I oppose this release because...
> > > > > 
> > > > > Thank you,
> > > > > 
> > > > > Gary Gregory,
> > > > > Release Manager (using key 86fdc7e2a11262cb)
> > > > > 
> > > > > For following is intended as a helper and refresher for reviewers.
> > > > > 
> > > > > Validating a release candidate
> > > > > ==============================
> > > > > 
> > > > > These guidelines are NOT complete.
> > > > > 
> > > > > Requirements: Git, Java, Maven.
> > > > > 
> > > > > You can validate a release from a release candidate (RC) tag as
> follows.
> > > > > 
> > > > > 1a) Clone and checkout the RC tag
> > > > > 
> > > > > git clone https://gitbox.apache.org/repos/asf/commons-csv.git
> --branch
> > > > > commons-csv-1.10.0-RC2 commons-csv-1.10.0-RC2
> > > > > cd commons-csv-1.10.0-RC2
> > > > > 
> > > > > 1b) Download and unpack the source archive from:
> > > > > 
> > > > > https://dist.apache.org/repos/dist/dev/commons/csv/1.10.0-RC2/source
> > > > > 
> > > > > 2) Check Apache licenses
> > > > > 
> > > > > This step is not required if the site includes a RAT report page which
> > > > > you then must check.
> > > > > 
> > > > > mvn apache-rat:check
> > > > > 
> > > > > 3) Check binary compatibility
> > > > > 
> > > > > Older components still use Apache Clirr:
> > > > > 
> > > > > This step is not required if the site includes a Clirr report page
> > > > > which you then must check.
> > > > > 
> > > > > mvn clirr:check
> > > > > 
> > > > > Newer components use JApiCmp with the japicmp Maven Profile:
> > > > > 
> > > > > This step is not required if the site includes a JApiCmp report page
> > > > > which you then must check.
> > > > > 
> > > > > mvn install -DskipTests -P japicmp japicmp:cmp
> > > > > 
> > > > > 4) Build the package
> > > > > 
> > > > > mvn -V clean package
> > > > > 
> > > > > You can record the Maven and Java version produced by -V in your VOTE
> > > > > reply.
> > > > > To gather OS information from a command line:
> > > > > Windows: ver
> > > > > Linux: uname -a
> > > > > 
> > > > > 5) Build the site for a single module project
> > > > > 
> > > > > Note: Some plugins require the components to be installed instead of
> > > > > packaged.
> > > > > 
> > > > > mvn site
> > > > > Check the site reports in:
> > > > > - Windows: target\site\index.html
> > > > > - Linux: target/site/index.html
> > > > > 
> > > > > -the end-
> > > > > 
> > > > > ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > > > For additional commands, e-mail: dev-help@commons.apache.org
> > > > > 
> > > > > 
> > > 
> > > 
> 
> 



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic