[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    [commons-ognl] branch master updated: null check not needed.
From:       ggregory () apache ! org
Date:       2021-02-28 15:07:17
Message-ID: 161452483770.25498.6611530194954172439 () gitbox ! apache ! org
[Download RAW message or body]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-ognl.git


The following commit(s) were added to refs/heads/master by this push:
     new 272c917  null check not needed.
272c917 is described below

commit 272c917af1dc6827c3f585e4a6de25a519c067c4
Author: Gary Gregory <garydgregory@gmail.com>
AuthorDate: Sun Feb 28 10:07:14 2021 -0500

    null check not needed.
---
 src/main/java/org/apache/commons/ognl/ASTAdd.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/commons/ognl/ASTAdd.java \
b/src/main/java/org/apache/commons/ognl/ASTAdd.java index b7aaae8..5fde25d 100644
--- a/src/main/java/org/apache/commons/ognl/ASTAdd.java
+++ b/src/main/java/org/apache/commons/ognl/ASTAdd.java
@@ -188,7 +188,7 @@ class ASTAdd
 
                     String expr = children[i].toGetSourceString( context, target );
 
-                    if ( ( expr != null && "null".equals( expr ) )
+                    if ( ( "null".equals( expr ) )
                         || ( !ASTConst.class.isInstance( children[i] )
                         && ( expr == null || expr.trim().isEmpty() ) ) )
                     {


[prev in list] [next in list] [prev in thread] [next in thread]