[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    =?utf-8?q?=5BGitHub=5D_=5Bcommons-lang=5D_garydgregory_commented_on_a_change?= =?utf-8?q?_in_pull_re
From:       GitBox <git () apache ! org>
Date:       2020-12-31 20:04:06
Message-ID: 160944504668.15632.9426452882433003265.asfpy () gitbox ! apache ! org
[Download RAW message or body]


garydgregory commented on a change in pull request #688:
URL: https://github.com/apache/commons-lang/pull/688#discussion_r550682944



##########
File path: src/test/java/org/apache/commons/lang3/time/FastDatePrinterTest.java
##########
@@ -432,4 +432,15 @@ public void testDayNumberOfWeek() {
         calendar.set(Calendar.DAY_OF_WEEK, Calendar.SUNDAY);
         assertEquals("7", printer.format(calendar.getTime()));
     }
+
+    @DefaultLocale(language = "en", country = "US")
+    @DefaultTimeZone("America/New_York")
+    @Test
+    public void testWeekYear() {
+        final GregorianCalendar cal = new GregorianCalendar(2020, 12, 31, 0, 0, 0);
+        final DatePrinter printer4Digits = getInstance("YYYY");
+        final DatePrinter printer2Digits = getInstance("YY");

Review comment:
       Hi,
   Thank you for your PR.
   What about "YYY"?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]