[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    =?utf-8?q?=5BGitHub=5D_=5Bcommons-beanutils=5D_SethFalco_commented_on_a_chan?= =?utf-8?q?ge_in_pull_
From:       GitBox <git () apache ! org>
Date:       2020-12-31 18:14:46
Message-ID: 160943848600.15632.1287302241554282302.asfpy () gitbox ! apache ! org
[Download RAW message or body]


SethFalco commented on a change in pull request #49:
URL: https://github.com/apache/commons-beanutils/pull/49#discussion_r550615540



##########
File path: src/test/java/org/apache/commons/beanutils2/converters/ConverterTestSuite.java
 ##########
@@ -41,7 +41,6 @@ public static Test suite() {
         testSuite.addTestSuite(BooleanConverterTestCase.class);
         testSuite.addTestSuite(ByteConverterTestCase.class);
         testSuite.addTestSuite(CalendarConverterTestCase.class);
-        testSuite.addTestSuite(CharacterConverterTestCase.class);
         testSuite.addTestSuite(ClassConverterTestCase.class);

Review comment:
       While doing this, I migrated tests of classes I was impacting to JUnit 4. When \
I changed the `CharacterConverter` I noticed that the line wasn't doing anything, so \
I removed it assuming it was just some pre-JUnit 4 boilerplate that wasn't needed \
anymore. ^-^' (Only ever used JUnit 4/5.)  
   I can see based on your comments I probably assumed wrong. ^-^' 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]