[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    [GitHub] [commons-imaging] christoffer-rydberg commented on a change in pull request #55: Add suppor
From:       GitBox <git () apache ! org>
Date:       2019-10-31 21:42:01
Message-ID: 157255812157.10568.16024526491757456561.gitbox () gitbox ! apache ! org
[Download RAW message or body]

christoffer-rydberg commented on a change in pull request #55: Add support to read multiple images from GIF
URL: https://github.com/apache/commons-imaging/pull/55#discussion_r341378065
 
 

 ##########
 File path: src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java
 ##########
 @@ -485,24 +495,35 @@ public Dimension getImageSize(final ByteSource byteSource, final Map<String, Obj
         if (bhi == null) {
             throw new ImageReadException("GIF: Couldn't read Header");
         }
-
-        final ImageDescriptor id = (ImageDescriptor) findBlock(blocks.blocks,
-                IMAGE_SEPARATOR);
-        if (id == null) {
-            throw new ImageReadException("GIF: Couldn't read ImageDescriptor");
-        }
-
-        // Prefer the size information in the ImageDescriptor; it is more
-        // reliable
-        // than the size information in the header.
-        return new Dimension(id.imageWidth, id.imageHeight);
+        
 
 Review comment:
   Thanks, I saw. Had some trailing spaces. Fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services
[prev in list] [next in list] [prev in thread] [next in thread]