[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    [commons-numbers] 02/09: NUMBERS-119: Improve relevant unit test to also check denominator
From:       erans () apache ! org
Date:       2019-06-30 21:55:49
Message-ID: 20190630215547.F184587AD9 () gitbox ! apache ! org
[Download RAW message or body]

This is an automated email from the ASF dual-hosted git repository.

erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit 5e212186d510d61b7238df45ef551b736b669c9b
Author: Schamschi <heinrich.bohne@gmx.at>
AuthorDate: Sat Jun 22 10:36:07 2019 +0200

    NUMBERS-119: Improve relevant unit test to also check denominator
---
 .../java/org/apache/commons/numbers/fraction/BigFractionTest.java  | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java \
b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
 index 2b0b377..74aefc4 100644
--- a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
                
+++ b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
 @@ -32,6 +32,11 @@ public class BigFractionTest {
         Assertions.assertEquals(BigInteger.valueOf(expectedDenominator), \
actual.getDenominator());  }
 
+    private void assertFraction(BigInteger expectedNumerator, BigInteger \
expectedDenominator, BigFraction actual) { +        \
Assertions.assertEquals(expectedNumerator, actual.getNumerator()); +        \
Assertions.assertEquals(expectedDenominator, actual.getDenominator()); +    }
+
     @Test
     public void testConstructor() {
         for (CommonTestCases.UnaryOperatorTestCase testCase : \
CommonTestCases.numDenConstructorTestCases()) { @@ -266,7 +271,7 @@ public class \
BigFractionTest {  }
         Assertions.assertEquals(1l, \
                BigFraction.from(Double.MAX_VALUE).getDenominatorAsLong());
         Assertions.assertEquals(1l, \
                BigFraction.from(Double.longBitsToDouble(0x0010000000000000L)).getNumeratorAsLong());
                
-        Assertions.assertEquals(1l, \
BigFraction.from(Double.MIN_VALUE).getNumeratorAsLong()); +        \
assertFraction(BigInteger.ONE, BigInteger.ONE.shiftLeft(1074), \
BigFraction.from(Double.MIN_VALUE));  }
 
     @Test


[prev in list] [next in list] [prev in thread] [next in thread]