[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    [jira] [Work logged] (TEXT-104) Jaro Winkler Distance refers to similarity
From:       "ASF GitHub Bot (JIRA)" <jira () apache ! org>
Date:       2018-12-30 13:19:00
Message-ID: JIRA.13110354.1508345660000.25770.1546175940215 () Atlassian ! JIRA
[Download RAW message or body]


     [ https://issues.apache.org/jira/browse/TEXT-104?focusedWorklogId=179786&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-179786 \
]

ASF GitHub Bot logged work on TEXT-104:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Dec/18 13:18
            Start Date: 30/Dec/18 13:18
    Worklog Time Spent: 10m 
      Work Description: saschaszott commented on issue #100: TEXT-104: Jaro Winkler \
                Distance refers to similarity
URL: https://github.com/apache/commons-text/pull/100#issuecomment-450560249
 
 
   Travis is complaining about two changes breaking downward compatibility:
   
   * field `INDEX_NOT_FOUND` was removed (this field was removed as it is not used \
                anymore)
   * method `protected int[] matches(java.lang.CharSequence, java.lang.CharSequence)` \
has been removed (this method was moved to `JaroWinklerSimilarity`; it is not \
required to duplicate this method in `JaroWinklerDistance`)  
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 179786)
    Time Spent: 20m  (was: 10m)

> Jaro Winkler Distance refers to similarity
> ------------------------------------------
> 
> Key: TEXT-104
> URL: https://issues.apache.org/jira/browse/TEXT-104
> Project: Commons Text
> Issue Type: Improvement
> Affects Versions: 1.1
> Reporter: Nikos Karagiannakis
> Priority: Trivial
> Fix For: 2.0
> 
> Time Spent: 20m
> Remaining Estimate: 0h
> 
> The 'apply' method returns the similarity score instead of the distance score as \
> implied from the class name.  It is stated in the javadoc, but it is not aligned \
> with the approach of the rest similarity scores in the same package (e.g \
> LevenshteinDetailedDistance).  Maybe a rename of the class or the method to avoid \
> confusion?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[prev in list] [next in list] [prev in thread] [next in thread]