[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    [jira] [Commented] (MATH-1455) mvn tests fail if JDK 9 is used
From:       "Gilles (JIRA)" <jira () apache ! org>
Date:       2018-03-31 11:59:00
Message-ID: JIRA.13149295.1522494698000.154903.1522497540057 () Atlassian ! JIRA
[Download RAW message or body]


    [ https://issues.apache.org/jira/browse/MATH-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421290#comment-16421290 \
] 

Gilles commented on MATH-1455:
------------------------------

I was aware of that, but I didn't how to deal with it other than disabling the test, \
which will only hide the issue that {{FastMath}} is not a "drop-in" replacement of \
{{Math}} as the documentation states.

The alternative of implementing the missing methods gets us back to never addressed \
                issues:
 * MATH-740
 * MATH-901
 * MATH-1113

AFAICT, the primary purpose of the (initial) {{FastMath}} code was accuracy. As it \
happens, several methods were also faster, but, as the above reports showed, the name \
was a bad choice.

First step would be to post to the "dev" ML, to see whether someone else agrees there \
is a fundamental issue, and is interested to fix it.

> mvn tests fail if JDK 9 is used
> -------------------------------
> 
> Key: MATH-1455
> URL: https://issues.apache.org/jira/browse/MATH-1455
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 4.X
> Reporter: Mark Williamson
> Priority: Minor
> 
> This is essentially the JDK9 version of MATH-1156
> {code:java}
> // code 
> Running org.apache.commons.math4.util.FastMathTest
> FastMath does not implement: public static long \
> java.lang.StrictMath.multiplyExact(long,int) FastMath does not implement: public \
> static double java.lang.StrictMath.fma(double,double,double) FastMath does not \
> implement: public static float java.lang.StrictMath.fma(float,float,float) FastMath \
> does not implement: public static long java.lang.StrictMath.multiplyFull(int,int) \
> FastMath does not implement: public static long \
> java.lang.StrictMath.multiplyHigh(long,long) FastMath does not implement: public \
> static long java.lang.StrictMath.floorDiv(long,int) FastMath does not implement: \
> public static int java.lang.StrictMath.floorMod(long,int) {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[prev in list] [next in list] [prev in thread] [next in thread]