[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    Re: [configuration] Checkstyle settings
From:       Matt Sicker <boards () gmail ! com>
Date:       2016-07-31 20:24:42
Message-ID: CACmp6koW6iSLBCN-+VtvfiqUC_bCH162tAsLJgUZ9tFWEvNZ-g () mail ! gmail ! com
[Download RAW message or body]


Fixing all the checkstyle errors first is kind of a prerequisite to
enabling it by default.

On 31 July 2016 at 15:10, Charles Honton <chas@honton.org> wrote:

> Why wouldn't we want build to fail early if incorrect style is used?
>
> chas
>
> > On Jul 31, 2016, at 11:09 AM, Oliver Heger <oliver.heger@oliver-heger.de>
> wrote:
> >
> > Hi,
> >
> > in revision 1742698 the checkstyle configuration has been changed. The
> > log says "fixed checkstyle violations, updated to latest version of
> > checkstyle-maven-plugin, ensure correct checkstyle configuration is
> > applied in all cases".
> >
> > I think with the new configuration checkstyle is now run on every mvn
> > install and causes the build to fail if there are checkstyle errors.
> > This is probably not what we want. What was the reason for this update,
> > i.e. under which circumstances was an incorrect checkstyle configuration
> > used?
> >
> > Thanks
> > Oliver
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
Matt Sicker <boards@gmail.com>


[prev in list] [next in list] [prev in thread] [next in thread]