[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    [jira] [Commented] (MATH-1259) Negative max in class Incrementor
From:       "Gilles (JIRA)" <jira () apache ! org>
Date:       2015-08-30 14:28:45
Message-ID: JIRA.12857492.1440063578000.205041.1440944925791 () Atlassian ! JIRA
[Download RAW message or body]


    [ https://issues.apache.org/jira/browse/MATH-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721531#comment-14721531 \
] 

Gilles commented on MATH-1259:
------------------------------

New class introduced in commit 818533e92bfb1c142ae4ce5be18ab92d1ae17025.

> Negative max in class Incrementor
> ---------------------------------
> 
> Key: MATH-1259
> URL: https://issues.apache.org/jira/browse/MATH-1259
> Project: Commons Math
> Issue Type: Bug
> Reporter: Gunel Jahangirova
> Priority: Minor
> Attachments: IntegerSequence.java
> 
> 
> In class Incrementor in the org.apache.commons.math4.util package it is possible to \
> pass a negative number for the max variable. Given that the count variable is \
> initialised to 0 by default, it means that canIncrement() method will always return \
> false.  I wonder whether it is an acceptable behaviour, given that documentation \
> says that Incrementor is a utility that increments a counter until a maximum is \
> reached. And in the case of negative max this maximum is not reachable at all. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[prev in list] [next in list] [prev in thread] [next in thread]