[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    [jira] [Commented] (BCEL-209) Bug fixes and improvements to InvokeDynamic and BootStrapMethods imple
From:       "Dave Brosius (JIRA)" <jira () apache ! org>
Date:       2015-02-28 21:09:04
Message-ID: JIRA.12772767.1423160951000.43305.1425157744899 () Atlassian ! JIRA
[Download RAW message or body]


    [ https://issues.apache.org/jira/browse/BCEL-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14341780#comment-14341780 \
] 

Dave Brosius commented on BCEL-209:
-----------------------------------

haven't really tested it, but the approach seems fine to me.

> Bug fixes and improvements to InvokeDynamic and BootStrapMethods implementation
> -------------------------------------------------------------------------------
> 
> Key: BCEL-209
> URL: https://issues.apache.org/jira/browse/BCEL-209
> Project: Commons BCEL
> Issue Type: Bug
> Reporter: Mark Roberts
> Attachments: counter.diff, invoke4.diff
> 
> 
> (Apologies in advance - this is a very large diff.)
> During the past year, both the Apache Commons BCEL team and our group here at the \
> UW independently completed the support for InvokeDynamic .  Some things we chose to \
> do the same way, but there are a few items that are quite different.  Trying not to \
> be too biased, I believe our method is better.  One of the larger differences is \
> your decision to add the abstract class NameSignatureMethod between FieldOrMethod \
> and CPInstruction and then have InvokeDynamic extend from that instead of from \
> InvokeInstruction.  To me this seems wrong.   In addition to forcing InvokeDynamic \
> to duplicate all the methods from InvokeInstruction and FieldOrMethod, it is \
> awkward that it is the only form of the Invoke Instruction that doesn't derive from \
> InvokeInstruction.  This patch also includes several methods missing from the \
> current implementation: alternative initializers, toString, and support for the \
> Visitor paradigm. There are bug fixes to Constants.java and InstructionFinder.java \
> as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[prev in list] [next in list] [prev in thread] [next in thread]