[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    [jira] [Commented] (NET-557) FTPClient Login suppression inconsistent
From:       "Sebb (JIRA)" <jira () apache ! org>
Date:       2014-11-30 18:13:12
Message-ID: JIRA.12749769.1413983851000.44228.1417371192577 () Atlassian ! JIRA
[Download RAW message or body]


    [ https://issues.apache.org/jira/browse/NET-557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229184#comment-14229184 \
] 

Sebb commented on NET-557:
--------------------------

I did consider this, but there is no guarantee that the user name is distinct from \
the other words in the message. For example, there might be a user called "User". Or \
"for" or "in". I agree this is somewhat unlikely, but it is not impossible.
And in other languages clashes may be more likely.

> FTPClient Login suppression inconsistent
> ----------------------------------------
> 
> Key: NET-557
> URL: https://issues.apache.org/jira/browse/NET-557
> Project: Commons Net
> Issue Type: Bug
> Components: FTP
> Affects Versions: 3.3
> Environment: Window 7, Java 7
> Reporter: Phil Dicke
> Priority: Minor
> 
> The following code prints out the user name in one instance and masks it in the \
> other.  The password is masked in both cases.  I would prefer the user name to be \
> masked in both cases as well. {code}
> FTPClient client = new FTPClient();
> client.addProtocolCommandListener(new PrintCommandListener(System.out, true));
> client.connect(host);
> client.login(user, pass);
> {code}
> Output (Notice the user name is printed on the response)
> {code}
> 220 Microsoft FTP Service
> USER *******
> 331 Password required for ftpTest.
> PASS *******
> 230 User ftpTest logged in.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[prev in list] [next in list] [prev in thread] [next in thread]