[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    [jira] [Closed] (DBCP-347) DelegatingStatement class has incomplete isWrapperFor method
From:       "Phil Steitz (JIRA)" <jira () apache ! org>
Date:       2014-05-31 4:16:04
Message-ID: JIRA.12478441.1288179208431.52619.1401509764108 () arcas
[Download RAW message or body]


     [ https://issues.apache.org/jira/browse/DBCP-347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel \
]

Phil Steitz closed DBCP-347.
----------------------------


> DelegatingStatement class has incomplete isWrapperFor method
> ------------------------------------------------------------
> 
> Key: DBCP-347
> URL: https://issues.apache.org/jira/browse/DBCP-347
> Project: Commons Dbcp
> Issue Type: Bug
> Environment: Windows 7. java version "1.6.0_21". Dell Latitude E6410.
> Reporter: Robert Poskrobek
> Fix For: 1.3.1, 1.4.1, 1.5.1, 2.0
> 
> Original Estimate: 1h
> Remaining Estimate: 1h
> 
> Currently org.apache.commons.dbcp.DelegatingStatement#isWrapperFor checks only if:
> 1. Requested class is assignable from the DelegatingStatement instance:        \
> iface.isAssignableFrom(getClass()) 2. Wrapped object is a wrapper for the requested \
> class:            _stmt.isWrapperFor(iface) I think there should be another option \
> checked i.e. requested class is assignable from the wrapped object's class. For \
> example:   iface.isAssignableFrom(_stmt.getClass()) This is especially that in fact \
> unwrap method properly assumes this possiblity i.e.:     return iface.cast(_stmt); \
> The whole method should be: public boolean isWrapperFor(Class<?> iface) throws \
> SQLException { return iface.isAssignableFrom(getClass()) || \
> iface.isAssignableFrom(_stmt.getClass()) || _stmt.isWrapperFor(iface); }



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[prev in list] [next in list] [prev in thread] [next in thread]