[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    svn commit: r1546738 - in /commons/proper/beanutils/trunk/src: main/java/org/apache/commons/beanutil
From:       oheger () apache ! org
Date:       2013-11-30 16:24:20
Message-ID: 20131130162420.A155B238883D () eris ! apache ! org
[Download RAW message or body]

Author: oheger
Date: Sat Nov 30 16:24:19 2013
New Revision: 1546738

URL: http://svn.apache.org/r1546738
Log:
StringBuffer -> StringBuilder

Modified:
    commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BeanUtilsBean.java
  commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/DynaProperty.java
  commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/DateTimeConverter.java
  commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/NumberConverter.java
  commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/locale/LocaleBeanUtilsBean.java
  commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/locale/converters/DateLocaleConverter.java
  commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira347TestCase.java
  commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/BooleanArrayConverterTestCase.java
  commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/ClassConverterTestCase.java
  commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/NumberConverterTestBase.java
  commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java


Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BeanUtilsBean.java
                
URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apa \
che/commons/beanutils/BeanUtilsBean.java?rev=1546738&r1=1546737&r2=1546738&view=diff \
                ==============================================================================
                
--- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BeanUtilsBean.java \
                (original)
+++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BeanUtilsBean.java \
Sat Nov 30 16:24:19 2013 @@ -326,7 +326,7 @@ public class BeanUtilsBean {
 
         // Trace logging (if enabled)
         if (log.isTraceEnabled()) {
-            StringBuffer sb = new StringBuffer("  copyProperty(");
+            StringBuilder sb = new StringBuilder("  copyProperty(");
             sb.append(bean);
             sb.append(", ");
             sb.append(name);
@@ -860,7 +860,7 @@ public class BeanUtilsBean {
 
         // Trace logging (if enabled)
         if (log.isTraceEnabled()) {
-            StringBuffer sb = new StringBuffer("  setProperty(");
+            StringBuilder sb = new StringBuilder("  setProperty(");
             sb.append(bean);
             sb.append(", ");
             sb.append(name);

Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/DynaProperty.java
                
URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apa \
che/commons/beanutils/DynaProperty.java?rev=1546738&r1=1546737&r2=1546738&view=diff \
                ==============================================================================
                
--- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/DynaProperty.java \
                (original)
+++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/DynaProperty.java \
Sat Nov 30 16:24:19 2013 @@ -250,7 +250,7 @@ public class DynaProperty implements Ser
     @Override
     public String toString() {
 
-        StringBuffer sb = new StringBuffer("DynaProperty[name=");
+        StringBuilder sb = new StringBuilder("DynaProperty[name=");
         sb.append(this.name);
         sb.append(",type=");
         sb.append(this.type);

Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/DateTimeConverter.java
                
URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apa \
che/commons/beanutils/converters/DateTimeConverter.java?rev=1546738&r1=1546737&r2=1546738&view=diff
 ==============================================================================
--- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/DateTimeConverter.java \
                (original)
+++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/DateTimeConverter.java \
Sat Nov 30 16:24:19 2013 @@ -193,7 +193,7 @@ public abstract class DateTimeConverter 
     public void setPatterns(String[] patterns) {
         this.patterns = patterns;
         if (patterns != null && patterns.length > 1) {
-            StringBuffer buffer = new StringBuffer();
+            StringBuilder buffer = new StringBuilder();
             for (int i = 0; i < patterns.length; i++) {
                 if (i > 0) {
                     buffer.append(", ");
@@ -577,7 +577,7 @@ public abstract class DateTimeConverter 
      */
     @Override
     public String toString() {
-        StringBuffer buffer = new StringBuffer();
+        StringBuilder buffer = new StringBuilder();
         buffer.append(toString(getClass()));
         buffer.append("[UseDefault=");
         buffer.append(isUseDefault());
@@ -607,7 +607,7 @@ public abstract class DateTimeConverter 
      */
     private void logFormat(String action, DateFormat format) {
         if (log().isDebugEnabled()) {
-            StringBuffer buffer = new StringBuffer(45);
+            StringBuilder buffer = new StringBuilder(45);
             buffer.append("    ");
             buffer.append(action);
             buffer.append(" with Format");

Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/NumberConverter.java
                
URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apa \
che/commons/beanutils/converters/NumberConverter.java?rev=1546738&r1=1546737&r2=1546738&view=diff
 ==============================================================================
--- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/NumberConverter.java \
                (original)
+++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/NumberConverter.java \
Sat Nov 30 16:24:19 2013 @@ -471,7 +471,7 @@ public abstract class NumberConverter ex
      */
     @Override
     public String toString() {
-        StringBuffer buffer = new StringBuffer();
+        StringBuilder buffer = new StringBuilder();
         buffer.append(toString(getClass()));
         buffer.append("[UseDefault=");
         buffer.append(isUseDefault());

Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/locale/LocaleBeanUtilsBean.java
                
URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apa \
che/commons/beanutils/locale/LocaleBeanUtilsBean.java?rev=1546738&r1=1546737&r2=1546738&view=diff
 ==============================================================================
--- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/locale/LocaleBeanUtilsBean.java \
                (original)
+++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/locale/LocaleBeanUtilsBean.java \
Sat Nov 30 16:24:19 2013 @@ -637,7 +637,7 @@ public class LocaleBeanUtilsBean extends
 
         // Trace logging (if enabled)
         if (log.isTraceEnabled()) {
-            StringBuffer sb = new StringBuffer("  setProperty(");
+            StringBuilder sb = new StringBuilder("  setProperty(");
             sb.append(bean);
             sb.append(", ");
             sb.append(name);

Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/locale/converters/DateLocaleConverter.java
                
URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apa \
che/commons/beanutils/locale/converters/DateLocaleConverter.java?rev=1546738&r1=1546737&r2=1546738&view=diff
 ==============================================================================
--- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/locale/converters/DateLocaleConverter.java \
                (original)
+++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/locale/converters/DateLocaleConverter.java \
Sat Nov 30 16:24:19 2013 @@ -17,18 +17,18 @@
 
 package org.apache.commons.beanutils.locale.converters;
 
-import org.apache.commons.beanutils.ConversionException;
-import org.apache.commons.beanutils.locale.BaseLocaleConverter;
-import org.apache.commons.logging.LogFactory;
-import org.apache.commons.logging.Log;
-
+import java.text.DateFormat;
+import java.text.DateFormatSymbols;
 import java.text.ParseException;
 import java.text.ParsePosition;
 import java.text.SimpleDateFormat;
-import java.text.DateFormat;
-import java.text.DateFormatSymbols;
 import java.util.Locale;
 
+import org.apache.commons.beanutils.ConversionException;
+import org.apache.commons.beanutils.locale.BaseLocaleConverter;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+
 
 /**
  * <p>Standard {@link org.apache.commons.beanutils.locale.LocaleConverter}
@@ -339,7 +339,7 @@ public class DateLocaleConverter extends
      */
     private String convertPattern(String pattern, String fromChars, String toChars) \
{  
-        StringBuffer converted = new StringBuffer();
+        StringBuilder converted = new StringBuilder();
         boolean quoted = false;
 
         for (int i = 0; i < pattern.length(); ++i) {

Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira347TestCase.java
                
URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apa \
che/commons/beanutils/bugs/Jira347TestCase.java?rev=1546738&r1=1546737&r2=1546738&view=diff
 ==============================================================================
--- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira347TestCase.java \
                (original)
+++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira347TestCase.java \
Sat Nov 30 16:24:19 2013 @@ -137,7 +137,7 @@ public class Jira347TestCase extends Tes
         String location = "file://" + \
dataFilePath.substring(0,dataFilePath.length()-"org.apache.commons.beanutils.memoryleaktests.pojotests".length());
  //System.out.println("location: " + location);
 
-        StringBuffer newString = new StringBuffer();
+        StringBuilder newString = new StringBuilder();
         for (int i=0;i<location.length();i++) {
             if (location.charAt(i)=='\\') {
                 newString.append("/");

Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/BooleanArrayConverterTestCase.java
                
URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apa \
che/commons/beanutils/converters/BooleanArrayConverterTestCase.java?rev=1546738&r1=1546737&r2=1546738&view=diff
 ==============================================================================
--- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/BooleanArrayConverterTestCase.java \
                (original)
+++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/BooleanArrayConverterTestCase.java \
Sat Nov 30 16:24:19 2013 @@ -17,11 +17,11 @@
 
 package org.apache.commons.beanutils.converters;
 
-import org.apache.commons.beanutils.ConvertUtils;
-import org.apache.commons.beanutils.ConversionException;
-
 import junit.framework.TestCase;
 
+import org.apache.commons.beanutils.ConversionException;
+import org.apache.commons.beanutils.ConvertUtils;
+
 /**
  * Test conversions of String[]->boolean[] and String->boolean[].
  *
@@ -82,7 +82,7 @@ public class BooleanArrayConverterTestCa
     public void testStandardStringConversion() {
         BooleanArrayConverter converter = new BooleanArrayConverter();
 
-        StringBuffer input = new StringBuffer();
+        StringBuilder input = new StringBuilder();
         boolean[] results;
 
         // string has {}
@@ -137,7 +137,7 @@ public class BooleanArrayConverterTestCa
 
         // string has only one element, quoted with '
         // Here we also pass an object of type String rather than the
-        // StringBuffer
+        // StringBuilder
         results = (boolean[]) converter.convert(null, "'yes'");
 
         assertNotNull(results);

Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/ClassConverterTestCase.java
                
URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apa \
che/commons/beanutils/converters/ClassConverterTestCase.java?rev=1546738&r1=1546737&r2=1546738&view=diff
 ==============================================================================
--- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/ClassConverterTestCase.java \
                (original)
+++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/ClassConverterTestCase.java \
Sat Nov 30 16:24:19 2013 @@ -68,7 +68,7 @@ public class ClassConverterTestCase exte
 
         assertEquals("Class Test", "java.lang.Integer", \
                converter.convert(String.class, Integer.class));
         assertEquals("Value Test", "foo", converter.convert(String.class, "foo"));
-        assertEquals("Value Test", "bar", converter.convert(String.class, new \
StringBuffer("bar"))); +        assertEquals("Value Test", "bar", \
                converter.convert(String.class, new StringBuilder("bar")));
         assertEquals("Null Test",   null, converter.convert(String.class, null));
     }
 
@@ -80,7 +80,7 @@ public class ClassConverterTestCase exte
 
         assertEquals("Class Test",        Integer.class, \
                converter.convert(Class.class, Integer.class));
         assertEquals("String Test",       Integer.class, \
                converter.convert(Class.class, "java.lang.Integer"));
-        assertEquals("StringBuffer Test", Integer.class, \
converter.convert(Class.class, new StringBuffer("java.lang.Integer"))); +        \
assertEquals("StringBuilder Test", Integer.class, converter.convert(Class.class, new \
StringBuilder("java.lang.Integer")));  
         // Invalid Test
         try {

Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/NumberConverterTestBase.java
                
URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apa \
che/commons/beanutils/converters/NumberConverterTestBase.java?rev=1546738&r1=1546737&r2=1546738&view=diff
 ==============================================================================
--- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/NumberConverterTestBase.java \
                (original)
+++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/NumberConverterTestBase.java \
Sat Nov 30 16:24:19 2013 @@ -366,7 +366,7 @@ public abstract class NumberConverterTes
         NumberConverter converter = makeConverter();
 
         // Other type --> String conversion
-        assertEquals("Default Convert ", "ABC", converter.convert(String.class, new \
StringBuffer("ABC"))); +        assertEquals("Default Convert ", "ABC", \
converter.convert(String.class, new StringBuilder("ABC")));  
     }
 

Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java
                
URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apa \
che/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java?rev=1546738&r1=1546737&r2=1546738&view=diff
 ==============================================================================
--- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java \
                (original)
+++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java \
Sat Nov 30 16:24:19 2013 @@ -507,7 +507,7 @@ public class MemoryLeakTestCase extends 
         String location = "file://" + \
dataFilePath.substring(0,dataFilePath.length()-"org.apache.commons.beanutils.memoryleaktests.pojotests".length());
  //System.out.println("location: " + location);
 
-        StringBuffer newString = new StringBuffer();
+        StringBuilder newString = new StringBuilder();
         for (int i=0;i<location.length();i++) {
             if (location.charAt(i)=='\\') {
                 newString.append("/");


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic