[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    Re: commons-lang pull request: LANG-848: Added isAnyBlank, isNoneBlank, isAnyEm...
From:       Gary Gregory <garydgregory () gmail ! com>
Date:       2012-10-31 15:28:23
Message-ID: CACZkXPwejs8nin=X52r_=Wne6rBkacAGiv=b6c3LeZjWNKSgxA () mail ! gmail ! com
[Download RAW message or body]


Thank you for the pull request.

There is a lot of code duplication that could be refactored.

Gary


On Wed, Oct 31, 2012 at 11:17 AM, amuthmann <git@git.apache.org> wrote:

> GitHub user amuthmann opened a pull request:
>
>     https://github.com/apache/commons-lang/pull/3
>
>     LANG-848: Added isAnyBlank, isNoneBlank, isAnyEmpty, isNoneEmpty
>
>     Those are the improvements described in LANG-848 including
>     ```java
>     public static boolean isAnyBlank(CharSequence... cs)
>     public static boolean isNoneBlank(CharSequence... cs)
>     public static boolean isAnyEmpty(CharSequence... cs)
>     public static boolean isNoneEmpty(CharSequence... cs)
>     ```
>
>     furthermore i implemtented the missing tests for isBlank, isNotBlank,
> isEmpty, isNotEmpty and the new calls.
>
> You can merge this pull request into a Git repository by running:
>
>     $ git pull https://github.com/amuthmann/commons-lang trunk
>
> Alternatively you can review and apply these changes as the patch at:
>
>     https://github.com/apache/commons-lang/pull/3.patch
>
> ----
> commit 2c49d2bb6851c1fa143165176de645a94f2670de
> Author: amuthmann <amuthmann@elladan.pro-vision.de>
> Date:   2012-10-31T08:13:15-07:00
>
>     LANG-848: Added isAnyBlank, isNoneBlank, isAnyEmpty, isNoneEmpty to
> StringUtils, implemented Tests
>
> ----
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


[prev in list] [next in list] [prev in thread] [next in thread]