[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    [jira] [Created] (POOL-216) GenericKeyedObjectPool.ensureMinIdle() does not need to check getMinIdle
From:       "Sebb (JIRA)" <jira () apache ! org>
Date:       2012-04-30 15:11:49
Message-ID: 1497324729.9539.1335798709586.JavaMail.tomcat () hel ! zones ! apache ! org
[Download RAW message or body]

Sebb created POOL-216:
-------------------------

             Summary: GenericKeyedObjectPool.ensureMinIdle() does not need to check \
getMinIdlePerKey()  Key: POOL-216
                 URL: https://issues.apache.org/jira/browse/POOL-216
             Project: Commons Pool
          Issue Type: Improvement
            Reporter: Sebb
            Priority: Minor


The private method GenericKeyedObjectPool.ensureMinIdle(K) checks getMinIdlePerKey().
However, when called by ensureMinIdle(void), this check has already been done.

The private method is only otherwise called by preparePool(K), so the check could be \
moved there.

This would eliminate one extra check per key when executing the protected \
ensureMinIdle() method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: \
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more \
information on JIRA, see: http://www.atlassian.com/software/jira

        


[prev in list] [next in list] [prev in thread] [next in thread]