[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    Re: [codec] Error in the Caverphone implemention
From:       Gary Gregory <garydgregory () gmail ! com>
Date:       2011-02-28 18:04:21
Message-ID: -8567461474161353708 () unknownmsgid
[Download RAW message or body]

Indeed. Aside from this, I've posted a new set of tests in SVN for
Caverphone. The failing tests are commented out until I or someone
else has a chance to dog in. There are no tests for the case outlined
in this case though (the mb stuff)

Gary

On Feb 28, 2011, at 11:16, Matt Benson <gudnabrsam@gmail.com> wrote:

> Finally, given the fact that we are discussing patches (which have to
> be granted IP blah blah blah anyway) as well as the fact that you are
> not subscribed to the developer list, this exchange should be
> conducted in JIRA.
>
> Matt
>
> On Mon, Feb 28, 2011 at 10:04 AM, Gary Gregory <garydgregory@gmail.com> wrote:
>> Would you be able to include a unit test patch in your diff file?
>>
>> Also, it seems that the examples from
>>
>> http://en.wikipedia.org/wiki/Caverphone
>>
>> do not match our code:
>>
>>            {"Lee", "L11111"},
>>            {"Thompson", "TMPSN1"},
>>
>> Hm...
>>
>> Thank you,
>> Gary
>>
>> On Mon, Feb 28, 2011 at 8:13 AM, Martin Nybo Andersen <tweek@tweek.dk>wrote:
>>
>>> Hi,
>>>
>>> I've found an error in the Caverphone language codec.
>>>
>>> According to the specs at page 2 line 6:
>>> "If the name ends with mb make it m2".
>>>
>>> Apparently is has been interpreted as:
>>> "If the name _starts_ with mb make it m2".
>>>
>>> The attached patch will fix it.
>>>
>>> Please CC me, as I'm not subscribed.
>>>
>>> Regards,
>>> Martin Nybo Andersen
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>
>>
>>
>> --
>> Thank you,
>> Gary
>>
>> http://garygregory.wordpress.com/
>> http://garygregory.com/
>> http://people.apache.org/~ggregory/
>> http://twitter.com/GaryGregory
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

[prev in list] [next in list] [prev in thread] [next in thread]