[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    [jira] Created: (NET-236) method
From:       Pasha_Arājums_(JIRA) <jira () apache ! org>
Date:       2008-10-29 15:07:44
Message-ID: 408818147.1225292864577.JavaMail.jira () brutus
[Download RAW message or body]

method SubnetUtils.SubnetInfo.isInRange(addr) returns incorrect result
----------------------------------------------------------------------

                 Key: NET-236
                 URL: https://issues.apache.org/jira/browse/NET-236
             Project: Commons Net
          Issue Type: Bug
    Affects Versions: 2.0
            Reporter: Pasha Arājums


current implementation failing to check low limit:
{code}
private boolean isInRange(int address)      { return ((address-low()) <= (high()-low())); }
{code}

suggested fix:
{code}
private boolean isInRange(int address)      { 
    normal = address-low();
    return (normal>=0 && (normal <= (high()-low())));
}
{code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[prev in list] [next in list] [prev in thread] [next in thread]