[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    Re: svn commit: r552049 - /jakarta/commons/proper/betwixt/trunk/src/java/org/apache/commons/betwixt/
From:       "Niall Pemberton" <niall.pemberton () gmail ! com>
Date:       2007-06-29 23:39:30
Message-ID: 55afdc850706291639s4b5771ccq86b425c894932de3 () mail ! gmail ! com
[Download RAW message or body]

On 6/29/07, mvdb@apache.org <mvdb@apache.org> wrote:
> Author: mvdb
> Date: Fri Jun 29 15:23:25 2007
> New Revision: 552049
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=552049
> Log:
> Fix Gump build failure and also made sure the fix runs on BeanUtils 1.7. The only \
> solution I could find is to copy the ConvertUtils.convert( object ) code and call \
> an internal method from Betwixt itself. If people want to use beanutils in the new \
> way, it's up to them to create a new defaultconverter.

Thinking about this change - I believe in solving one issue you create
another. Consider someone that has created a custom ConvertUtilsBean
implementation and overriden the convert(Object) method and registered
that in ConvertUtils - now their method no longer gets invoked so IMO
this is as much as a break in compatibility for Betwixt users as the
issue its trying to resolve.

Niall

> Sanity check by Robert would be highly appreciated..
> 
> Modified:
> jakarta/commons/proper/betwixt/trunk/src/java/org/apache/commons/betwixt/strategy/ConvertUtilsObjectStringConverter.java
>  
> Modified: jakarta/commons/proper/betwixt/trunk/src/java/org/apache/commons/betwixt/strategy/ConvertUtilsObjectStringConverter.java
>                 
> URL: http://svn.apache.org/viewvc/jakarta/commons/proper/betwixt/trunk/src/java/org/ \
> apache/commons/betwixt/strategy/ConvertUtilsObjectStringConverter.java?view=diff&rev=552049&r1=552048&r2=552049
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]