[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    svn commit: r159615 - in
From:       olegk () apache ! org
Date:       2005-03-31 17:29:01
Message-ID: 20050331172901.44259.qmail () minotaur ! apache ! org
[Download RAW message or body]

Author: olegk
Date: Thu Mar 31 09:28:59 2005
New Revision: 159615

URL: http://svn.apache.org/viewcvs?view=rev&rev=159615
Log:
Some extra debug log entries for the authenticaton process

Contributed by Oleg Kalnichevski

Modified:
    jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpMethodDirector.java
  jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/auth/AuthChallengeProcessor.java


Modified: jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpMethodDirector.java
                
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/httpclient/trunk/src/java/or \
g/apache/commons/httpclient/HttpMethodDirector.java?view=diff&r1=159614&r2=159615 \
                ==============================================================================
                
--- jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpMethodDirector.java \
                (original)
+++ jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpMethodDirector.java \
Thu Mar 31 09:28:59 2005 @@ -188,6 +188,7 @@
                 }
                 if (isAuthenticationNeeded(method)) {
                     if (processAuthenticationResponse(method)) {
+                        LOG.debug("Retry authentication");
                         retry = true;
                     }
                 }
@@ -668,6 +669,7 @@
         Map challenges = AuthChallengeParser.parseChallenges(
             method.getResponseHeaders(WWW_AUTH_CHALLENGE));
         if (challenges.isEmpty()) {
+            LOG.debug("Authentication challenge(s) not found");
             return false; 
         }
         AuthScheme authscheme = null;
@@ -689,8 +691,11 @@
         AuthScope authscope = new AuthScope(
             host, port, 
             authscheme.getRealm(), 
-            authscheme.getSchemeName());  
-
+            authscheme.getSchemeName());
+        
+        if (LOG.isDebugEnabled()) {
+            LOG.debug("Authentication scope: " + authscope);
+        }
         if (authstate.isAuthAttempted() && authscheme.isComplete()) {
             // Already tried and failed
             Credentials credentials = promptForCredentials(
@@ -731,6 +736,7 @@
         Map proxyChallenges = AuthChallengeParser.parseChallenges(
             method.getResponseHeaders(PROXY_AUTH_CHALLENGE));
         if (proxyChallenges.isEmpty()) {
+            LOG.debug("Proxy authentication challenge(s) not found");
             return false; 
         }
         AuthScheme authscheme = null;
@@ -749,6 +755,9 @@
             authscheme.getRealm(), 
             authscheme.getSchemeName());  
 
+        if (LOG.isDebugEnabled()) {
+            LOG.debug("Proxy authentication scope: " + authscope);
+        }
         if (authstate.isAuthAttempted() && authscheme.isComplete()) {
             // Already tried and failed
             Credentials credentials = promptForProxyCredentials(
@@ -837,6 +846,7 @@
         final HttpParams params, 
         final AuthScope authscope)
     {
+        LOG.debug("Credentials required");
         Credentials creds = null;
         CredentialsProvider credProvider = 
             (CredentialsProvider)params.getParameter(CredentialsProvider.PROVIDER);
@@ -853,6 +863,8 @@
                     LOG.debug(authscope + " new credentials given");
                 }
             }
+        } else {
+            LOG.debug("Credentials provider not available");
         }
         return creds;
     }
@@ -862,6 +874,7 @@
         final HttpParams params,
         final AuthScope authscope) 
     {
+        LOG.debug("Proxy credentials required");
         Credentials creds = null;
         CredentialsProvider credProvider = 
             (CredentialsProvider)params.getParameter(CredentialsProvider.PROVIDER);
@@ -878,6 +891,8 @@
                     LOG.debug(authscope + " new credentials given");
                 }
             }
+        } else {
+            LOG.debug("Proxy credentials provider not available");
         }
         return creds;
     }

Modified: jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/auth/AuthChallengeProcessor.java
                
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/httpclient/trunk/src/java/or \
g/apache/commons/httpclient/auth/AuthChallengeProcessor.java?view=diff&r1=159614&r2=159615
 ==============================================================================
--- jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/auth/AuthChallengeProcessor.java \
                (original)
+++ jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/auth/AuthChallengeProcessor.java \
Thu Mar 31 09:28:59 2005 @@ -158,6 +158,7 @@
                 " authorization challenge expected, but not found");
         }
         authscheme.processChallenge(challenge);
+        LOG.debug("Authorization challenge processed");
         return authscheme;
     }
 }



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]