[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jakarta-commons-dev
Subject:    cvs commit: jakarta-commons-sandbox/jelly/src/java/org/apache/commons/jelly/tags/sql QueryTag.java
From:       jstrachan () apache ! org
Date:       2002-09-30 17:31:40
[Download RAW message or body]

jstrachan    2002/09/30 10:31:39

  Modified:    jelly/src/java/org/apache/commons/jelly/tags/sql
                        QueryTag.java
  Log:
  Added a comment to the code on the point raised by Kevin Jones and Steve Downey on \
the order of closing of result set & statement  
  Revision  Changes    Path
  1.14      +3 -0      \
jakarta-commons-sandbox/jelly/src/java/org/apache/commons/jelly/tags/sql/QueryTag.java
  
  Index: QueryTag.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons-sandbox/jelly/src/java/org/apache/commons/jelly/tags/sql/QueryTag.java,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- QueryTag.java	30 Sep 2002 17:30:28 -0000	1.13
  +++ QueryTag.java	30 Sep 2002 17:31:39 -0000	1.14
  @@ -218,6 +218,9 @@
               result = new ResultImpl(rs, startRow, maxRows);
               context.setVariable(var, result);
               
  +            // always close the result set first since it may be closed by 
  +            // JDBC 3 when closing statements 
  +            
               // lets nullify before we close in case we get exceptions
               // while closing, we don't want to try to close again
               ResultSet tempRs = rs;
  
  
  

--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


[prev in list] [next in list] [prev in thread] [next in thread]