[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ipsec-tools-devel
Subject:    Re: [Ipsec-tools-devel] [PATCH] Incorrect spi_size
From:       Brian Haley <brian.haley () hp ! com>
Date:       2008-02-25 21:28:33
Message-ID: 47C33301.4050508 () hp ! com
[Download RAW message or body]

Emmanuel Dreyfus wrote:
> Brian Haley <brian.haley@hp.com> wrote:
> 
>>> Committed in HEAD and 0.7 branch. Indeed the code was not doing what was
>>> intended. I just hope that the intended way will not undercover a bug.
>> Right, I'm not sure if it should be !=, <=, or some other check, I was
>> counting on someone who knew the code better to review.
> 
> Mmmm... Perhaps I should back out on 0.7 and just keep it in HEAD first,
> then?

Yes, I suppose.  The change doesn't break my configuration, but I'm not 
sure I was ever hitting this check anyways - I had triggered the error 
right above it with an invalid config file so just noticed this.

I can do some more testing if I could get some more info on what this 
check was supposed to do, and a few examples of some valid/invalid 
configs in this area.

-Brian

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Ipsec-tools-devel mailing list
Ipsec-tools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipsec-tools-devel
[prev in list] [next in list] [prev in thread] [next in thread]