[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ipfire-development
Subject:    [PATCH v2 0/4] proxy.cgi fixes for bugzilla #10852
From:       Bernhard Held <berny156 () gmx ! de>
Date:       2018-02-12 22:19:28
Message-ID: 20180212221932.29122-1-berny156 () gmx ! de
[Download RAW message or body]

v2 with following changes:

Network::network_qual: Improved check if array is fully defined.
Honestly, the testsuite of the unpatched file still fails on my IPFire
for an unknown reason. The patches fixe the issue for me using perl
v5.12.3 as well as v5.26.1.

Network::network2bin: 'return undef;' doesn't return an empty list
causing lots of headaches. Popular sites strongly recommend to use
'return;' instead of 'return undef;'. Maybe 'return undef;' should be
avoided everywhere in IPFire.

Have fun,
Bernhard
[prev in list] [next in list] [prev in thread] [next in thread]