[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ipfire-development
Subject:    Re: [PATCH] Network::network_equal: fix definition check of array
From:       Michael Tremer <michael.tremer () ipfire ! org>
Date:       2018-02-12 11:08:36
Message-ID: 1518433716.2541.64.camel () ipfire ! org
[Download RAW message or body]

Hi,

the perl version is a bit outdated that we are running on IPFire. It's perl
5.12.3: https://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=lfs/perl;h=0c239318c39
15cdfbad3ff602b075bb425513bf3;hb=HEAD

I ran that testsuite with exactly that version of perl.

Best,
-Michael

On Mon, 2018-02-12 at 01:19 +0100, Bernhard Held wrote:
> On 02/12/2018 at 12:38 AM, Michael Tremer wrote:
> > Hello,
> > 
> > this patch shows the following perl errors:
> > 
> > defined(@array) is deprecated at config/cfgroot/network-functions.pl line
> > 114.
> > 	(Maybe you should just omit the defined()?)
> > defined(@array) is deprecated at config/cfgroot/network-functions.pl line
> > 114.
> > 	(Maybe you should just omit the defined()?)
> 
> Interesting, I'm testing on IPFire 2.19. Here perl 5.12 prefers the '$'.
> My host with Perl 5.26 indeed prefers the '@' as well.
> 
> Which perl versions apply for network-functions.pl?
> 
> > You can use the testsuite at the bottom of the file to confirm that the
> > functions are doing what they are supposed to do.
> 
> Thanks, this helps ;-)
> 
> Regards,
> Bernhard
[prev in list] [next in list] [prev in thread] [next in thread]