[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ipfire-development
Subject:    Re: AW: Upgrade to Apache 2.4
From:       Michael Tremer <michael.tremer () ipfire ! org>
Date:       2017-04-18 12:05:12
Message-ID: 1492517112.11653.57.camel () ipfire ! org
[Download RAW message or body]


Hi,

On Sun, 2017-04-16 at 23:13 +0200, Wolfgang Apolinarski wrote:
> Hi Michael,
> 
> I read the page before posting to the list, but

Good.

> a) I wanted to make sure that you are at all interested in an upgrade to
> apache 2.4

Yes we are of course.

> b) It says "You may also use git send-email or send a Git pull request which
> is the recommended way for patch sets."
> (and I thought that git pull request is what Github (in this case) is for)

We do not use GitHub. Our repositories are mirrored there but everything else is
disabled. It is unfortunately impossible to disable pull requests. But
nevertheless, there is no chance to comment on them and keep a good record and
so on. There are quite a few conversations on this list where I explain more.

A pull request instead of sending the patchset only makes sense for more than 20
 patches that need to be merged all together.

> I broke down the patch into 4 smaller patches, but I wanted to make sure that
> each patch can be applied individually such that IPFire is not only building,
> but apache also does not crash on startup.

Each patch should allow the system to build and run.

> Therefore, the apache-update patch is still not that small, but the
> configuration changes are necessary because of the changed syntax.

Yes, it will be large because of the rootfile alone, but there is no way around
it. It would be good not to make it larger by adding more changes.

> I will now configure and use git send-email for the patches.

-Michael

> 
> Best regards,
> Wolfgang
> PS.: I still have to build and test the individual patches, since I only
> tested the complete patch-set.
> 
> -----Ursprüngliche Nachricht-----
> Von: Michael Tremer [mailto:michael.tremer@ipfire.org]  
> Gesendet: Sonntag, 16. April 2017 18:13
> An: Wolfgang Apolinarski <wolfgang@apolinarski.de>; development@lists.ipfire.o
> rg
> Betreff: Re: Upgrade to Apache 2.4
> 
> Hello,
> 
> could you please post this as explained here:
> 
>    http://wiki.ipfire.org/devel/submit-patches
> 
> This will allow us to comment on the changes. I do have quite a number of
> questions and remarks.
> 
> This is also a very huge patch, so I would prefer it if it was broken into
> smaller individual patches. It is all explained on the wiki.
> 
> Best,
> -Michael
> 
> On Fri, 2017-04-14 at 16:25 +0200, Wolfgang Apolinarski wrote:
> > Hi everyone,
> > 
> > I created an upgrade to Apache 2.4:
> > https://github.com/wapolinar/ipfire-2.x/tree/apache_24
> > 
> > It should be up-to-date with the current next branch, but I could  
> > rebase/merge it with whatever branch you want me to.
> > I also had to update some configuration files of addons, because they  
> > did not comply to the Apache 2.4 syntax. Please have a look at this  
> > changes as well, I tested them on my virtual IPFire machine and as far  
> > as I could see it they are working, but there might be some problems.
> > 
> > I'm willing to change the apache configuration of other  
> > addons/configuration files, if necessary.
> > 
> > If you think that IPFire does not need this update, this is also ok to  
> > me, I started creating it, after the discussion about the  
> > htpasswd-tool started.
> > 
> > Best regards,
> > Wolfgang
> > 
> 
> 
["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]