[prev in list] [next in list] [prev in thread] [next in thread] 

List:       intel-wired-lan
Subject:    Re: [Intel-wired-lan] [PATCH RFC iwl-next 02/12] idpf: stop using macros for accessing queue descrip
From:       Mina Almasry <almasrymina () google ! com>
Date:       2024-05-16 17:45:49
Message-ID: CAHS8izMRaw3TyURSwdoAnd67EHpgdfazm7-jOFUAWuCAOd39ng () mail ! gmail ! com
[Download RAW message or body]

On Fri, May 10, 2024 at 8:28 AM Alexander Lobakin
<aleksander.lobakin@intel.com> wrote:
>
> In C, we have structures and unions.
> Casting `void *` via macros is not only error-prone, but also looks
> confusing and awful in general.
> In preparation for splitting the queue structs, replace it with a
> union and direct array dereferences.
>
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>

FWIW,

Reviewed-by: Mina Almasry <almasrymina@google.com>

-- 
Thanks,
Mina
[prev in list] [next in list] [prev in thread] [next in thread]