[prev in list] [next in list] [prev in thread] [next in thread] 

List:       intel-wired-lan
Subject:    Re: [Intel-wired-lan] [PATCH v10 iwl-next 02/12] ice: Introduce helper to get tmr_cmd_reg values
From:       "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha () intel ! com>
Date:       2024-05-17 7:30:16
Message-ID: CYYPR11MB84290C992003B4E12B0DAC7DBDEE2 () CYYPR11MB8429 ! namprd11 ! prod ! outlook ! com
[Download RAW message or body]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of K=
arol Kolacinski
> Sent: Wednesday, April 24, 2024 7:00 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org; Kubalewski, Arkadiusz <arkadiusz.kubalewski@i=
ntel.com>; Kolacinski, Karol <karol.kolacinski@intel.com>; Nguyen, Anthony =
L <anthony.l.nguyen@intel.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@int=
el.com>; Keller, Jacob E <jacob.e.keller@intel.com>
> Subject: [Intel-wired-lan] [PATCH v10 iwl-next 02/12] ice: Introduce help=
er to get tmr_cmd_reg values
>
> From: Jacob Keller <jacob.e.keller@intel.com>
>
> Multiple places in the driver code need to convert enum ice_ptp_tmr_cmd v=
alues into register bits for both the main timer and the PHY port timers. T=
he main MAC register has one bit scheme for timer commands, while the PHY c=
ommands use a different scheme.
>
> The E810 and E830 devices use the same scheme for port commands as used f=
or the main timer. However, E822 and ETH56G hardware has a separate scheme =
used by the PHY.
>
> Introduce helper functions to convert the timer command enumeration into =
the register values, reducing some code duplication, and making it easier t=
o later refactor the individual port write commands.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
> Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
> ---
> V4 -> V5: Changed operation sequence to shift tmr_idx instead of cmd_val
>
>  drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 140 ++++++++++++--------
>  drivers/net/ethernet/intel/ice/ice_ptp_hw.h |   2 +-
>  2 files changed, 89 insertions(+), 53 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Co=
ntingent worker at Intel)

[prev in list] [next in list] [prev in thread] [next in thread]