[prev in list] [next in list] [prev in thread] [next in thread] 

List:       intel-wired-lan
Subject:    Re: [Intel-wired-lan] [PATCH iwl-next 3/6] i40e: Use DECLARE_BITMAP for flags and hw_features fields
From:       "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha () intel ! com>
Date:       2023-10-31 10:22:56
Message-ID: BL0PR11MB31228D74A9C538CDA9E2E8D3BDA0A () BL0PR11MB3122 ! namprd11 ! prod ! outlook ! com
[Download RAW message or body]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Ivan Vecera
> Sent: Saturday, October 21, 2023 1:08 AM
> To: netdev@vger.kernel.org
> Cc: Eric Dumazet <edumazet@google.com>; dacampbe@redhat.com; Richard Cochran \
> <richardcochran@gmail.com>; Brandeburg, Jesse <jesse.brandeburg@intel.com>; open \
> list <linux-kernel@vger.kernel.org>; Nguyen, Anthony L \
> <anthony.l.nguyen@intel.com>; moderated list:INTEL ETHERNET DRIVERS \
> <intel-wired-lan@lists.osuosl.org>; Keller, Jacob E <jacob.e.keller@intel.com>; \
> Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; David S. Miller \
>                 <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH iwl-next 3/6] i40e: Use DECLARE_BITMAP for flags \
> and hw_features fields in i40e_pf 
> Convert flags and hw_features fields from i40e_pf from u32 to
> bitmaps and their usage to use bit access functions.
> 
> Changes:
> - Convert "pf_ptr->(flags|hw_features) & FL" to "test_bit(FL, ...)"
> - Convert "pf_ptr->(flags|hw_features) |= FL" to "set_bit(FL, ...)"
> - Convert "pf_ptr->(flags|hw_features) &= ~FL" to "clear_bit(FL, ...)"
> - Rename flag field to bitno in i40e_priv_flags and adjust ethtool
> callbacks to work with flags bitmap
> - Rename flag names where '_ENABLED'->'_ENA' and '_DISABLED'->'_DIS'
> like in ice driver
> 
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e.h        | 165 ++---
> drivers/net/ethernet/intel/i40e/i40e_dcb_nl.c |  24 +-
> .../net/ethernet/intel/i40e/i40e_debugfs.c    |   4 +-
> .../net/ethernet/intel/i40e/i40e_ethtool.c    | 209 ++++---
> drivers/net/ethernet/intel/i40e/i40e_main.c   | 587 +++++++++---------
> drivers/net/ethernet/intel/i40e/i40e_ptp.c    |  26 +-
> drivers/net/ethernet/intel/i40e/i40e_txrx.c   |  20 +-
> drivers/net/ethernet/intel/i40e/i40e_txrx.h   |   4 +-
> .../ethernet/intel/i40e/i40e_virtchnl_pf.c    |  20 +-
> 9 files changed, 544 insertions(+), 515 deletions(-)
> 

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent \
worker at Intel)

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan


[prev in list] [next in list] [prev in thread] [next in thread]