[prev in list] [next in list] [prev in thread] [next in thread] 

List:       intel-wired-lan
Subject:    Re: [Intel-wired-lan] [net-next v3 02/15] idpf: add module register and probe functionality
From:       "Tantilov, Emil S" <emil.s.tantilov () intel ! com>
Date:       2023-04-28 23:05:34
Message-ID: 9110854d-7bdc-db02-068e-3cc75800092d () intel ! com
[Download RAW message or body]



On 4/27/2023 4:24 PM, Shannon Nelson wrote:
> On 4/26/23 7:09 PM, Emil Tantilov wrote:
>>
>> From: Phani Burra <phani.r.burra@intel.com>
>>
> 
> [...]
> 
>> +static int idpf_probe(struct pci_dev *pdev, const struct 
>> pci_device_id *ent)
>> +{
>> +       struct device *dev = &pdev->dev;
>> +       struct idpf_adapter *adapter;
>> +       int err;
>> +
>> +       adapter = kzalloc(sizeof(*adapter), GFP_KERNEL);
>> +       if (!adapter)
>> +               return -ENOMEM;
>> +       adapter->pdev = pdev;
> 
> The custom more recently has been to allocate the devlink struct early 
> on and build the device struct from that allocation.  You likely will 
> want to follow along and play in the devlink world.
> 
> sln
> 

Good point, we'll keep that in mind for future development.

Thanks,
Emil
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

[prev in list] [next in list] [prev in thread] [next in thread]