[prev in list] [next in list] [prev in thread] [next in thread] 

List:       intel-wired-lan
Subject:    Re: [Intel-wired-lan] [PATCH net v1] ice: Fix DSCP PFC TLV creation
From:       Tony Nguyen <anthony.l.nguyen () intel ! com>
Date:       2023-01-31 21:40:51
Message-ID: cee63d27-872b-cb4e-dfb6-93cf89e87b95 () intel ! com
[Download RAW message or body]

On 1/27/2023 5:24 AM, Karen Ostrowska wrote:
> From: Dave Ertman <david.m.ertman@intel.com>
> 
> When creating the TLV to send to the FW for configuring DSCP mode PFC,the
> PFCENABLE field was being masked with a 4 bit mask (0xF), but this is an 8
> bit bitmask for enabled classes for PFC.  This means that traffic classes
> 4-7 could not be enabled for PFC.
> 
> Remove the mask completely, as it is not necessary, as we are assigning 8
> bits to an 8 bit field.
> 
> Fixes: 2a87bd73e50d ("ice: Add DSCP support")
> Signed-off-by: Dave Ertman <david.m.ertman@intel.com>
> Signed-off-by: Karen Ostrowska <karen.ostrowska@intel.com>
> ---

Applied, however, this should be a v2 (with changelog)

>   drivers/net/ethernet/intel/ice/ice_dcb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_dcb.c b/drivers/net/ethernet/intel/ice/ice_dcb.c
> index 6be02f9b0b8c..789b99963910 100644
> --- a/drivers/net/ethernet/intel/ice/ice_dcb.c
> +++ b/drivers/net/ethernet/intel/ice/ice_dcb.c
> @@ -1372,7 +1372,7 @@ ice_add_dscp_pfc_tlv(struct ice_lldp_org_tlv *tlv, struct ice_dcbx_cfg *dcbcfg)
>   	tlv->ouisubtype = htonl(ouisubtype);
>   
>   	buf[0] = dcbcfg->pfc.pfccap & 0xF;
> -	buf[1] = dcbcfg->pfc.pfcena & 0xF;
> +	buf[1] = dcbcfg->pfc.pfcena;
>   }
>   
>   /**
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
[prev in list] [next in list] [prev in thread] [next in thread]