[prev in list] [next in list] [prev in thread] [next in thread] 

List:       inn-workers
Subject:    Re: INN indentation
From:       Julien_ÉLIE <julien () trigofacile ! com>
Date:       2021-10-21 20:09:04
Message-ID: de616570-7a9a-938d-a103-a2612faa1f84 () trigofacile ! com
[Download RAW message or body]

Hi all,

>> AlignConsecutiveMacros: AcrossEmptyLinesAndComments
>> may be better but only available in clang-format 13 (not yet released!)
>> It think it would permit to have 62 at the same level here:
> 
>> #if defined(HAVE_OPENSSL) || defined(HAVE_SASL)
>> #    define PERMrequire_ssl 62
>> #    define PERMMAX         63
>> #else
>> #    define PERMMAX 62
>> #endif
> 
> Oh, that will be very nice once that's released.  That's one of the
> formatting decisions that always bugged me.

Sure it will be nice!
Amusingly, I've found out a drawback of alignment, in nnrpd/line.c:

             zstream_inflate_needed = true;
             n = 0;
         }
#endif                /* HAVE_ZLIB */
     } while (n == 0); /* Split SASL blob, need to read more data. */

     return n;
}

I think clang-format should not align these comments, it seems weird. 
But well, comments are aligned!

-- 
Julien ÉLIE

« Attention aux bugs dans le code ci-dessus. Je ne l'ai pas testé, j'ai
   seulement prouvé qu'il était correct. » (Donald Knuth)
_______________________________________________
inn-workers mailing list
inn-workers@lists.isc.org
https://lists.isc.org/mailman/listinfo/inn-workers

[prev in list] [next in list] [prev in thread] [next in thread]