[prev in list] [next in list] [prev in thread] [next in thread] 

List:       inn-workers
Subject:    Re: [PATCH] innfeed does not reopen (rotated) log file
From:       Julien_ÉLIE <julien () trigofacile ! com>
Date:       2013-04-29 19:50:06
Message-ID: 517ECEEE.3060108 () trigofacile ! com
[Download RAW message or body]

Hi Florian,

> I revisited your earlier suggestion to add a call to openLogFile() to
> the sighup handler (sigusr1 is already used for increasing debug
> level), and this is what I'm successfully running with now:

Thanks for your proposal of patch.

I wonder whether sending the signal twice is necessary (once before the =

rotation, and once after the rotation).  Isn't it enough to send it =

after the rotation?

That is to say we keep a "ctlinnd flushlogs" before the rotation, and we =

add the innfeed signal after the rotation (instead of the second =

"ctlinnd flushlogs" introduced in a recent commit, that should be reverted)?

It would then be fine for INN 2.5.  And we could consider a complete fix =

for INN 2.6 with the addition of "ctlinnd prerotatelogs"/"ctlinnd =

postrotatelogs"?

-- =

Julien =C9LIE

=AB J'adore =EAtre pris en flagrant d=E9lire. =BB (Raymond Devos)
_______________________________________________
inn-workers mailing list
inn-workers@lists.isc.org
https://lists.isc.org/mailman/listinfo/inn-workers
[prev in list] [next in list] [prev in thread] [next in thread]