[prev in list] [next in list] [prev in thread] [next in thread] 

List:       inn-workers
Subject:    Re: [PATCH] innfeed does not reopen (rotated) log file
From:       Julien_ÉLIE <julien () trigofacile ! com>
Date:       2013-01-16 20:52:46
Message-ID: 50F7131E.6090900 () trigofacile ! com
[Download RAW message or body]

Hi Florian,

>> Does anyone have any concerns about this and think we should add a
>> separate signal for log rotation?
>
> It's the same as what other daemons (e.g. apache2) do after log rotation
> / on SIGHUP, so it shouldn't come as too much of a surprise IMHO.

OK, thanks for having answered, Florian and Jeffrey.



> Related to the original issue, yesterday I noticed that ninpaths and
> controlchan have a deleted log/OLD/errlog on stdout and stderr. Perhaps
> 'ctlinnd flushlogs' as used in scanlogs should also cause flushing of
> all channel / exploder feeds?

Couldn't we just run
   ctlinnd name ''
and
   ctlinnd flush xxx
on every "proc" type entry returned by the command?


It would solve the problem you mention, and also the flush of innfeed 
log files because all running innfeed would be restarted.


Example:

21:46 news@trigo ~% ctlinnd name ''
control:12:control::
localconn:14:localconn::
remconn:15:remconn::
remconn:17:remconn::
controlchan!:22:proc:16605:
innfeed!:25:proc:16606:
source-archive!:562:proc:16608:
nocem!:599:proc:16609:
feeder.eternal-september.org:674:nntp:26:paused
localhost:759:cancel:227:
news.litech.org:762:file::
inpaths!:805:proc:3525:

=> We would flush "controlchan!", "innfeed!", "source-archive!", 
"nocem!" and "inpaths!".




> PS: insignificant typo:
>
> --- a/doc/pod/newsfeeds.pod
> +++ b/doc/pod/newsfeeds.pod
> @@ -638,7 +638,7 @@ at its leisure.  File feeds are most frequently used in combination with
>   nntpsend(8).
>
>   A program feed (B<Tp>) spawns a given program for every article that the
> -site receives.  The I<paramter> field must be the command line to execute,
> +site receives.  The I<parameter> field must be the command line to execute,
>   and should contain one instance of C<%s>, which will be replaced by the
>   storage API token of the article (the actual article can be retrieved by
>   the program using sm(8)).  The program will not receive anything on

Fixed!
Thanks Florian,

-- 
Julien ÉLIE

« Le beau est toujours bizarre. » (Baudelaire)
_______________________________________________
inn-workers mailing list
inn-workers@lists.isc.org
https://lists.isc.org/mailman/listinfo/inn-workers
[prev in list] [next in list] [prev in thread] [next in thread]