[prev in list] [next in list] [prev in thread] [next in thread] 

List:       inn-workers
Subject:    Kerberos at configure time for INN 2.4.4
From:       Julien_ÉLIE <julien () trigofacile ! com>
Date:       2008-04-29 10:46:53
Message-ID: 4ADA172FAE904D58B1677A0EC4555700 () Iulius
[Download RAW message or body]

Hi,

It should perhaps be included in INN 2.4.4 since otherwise compilation
might not succeed (because of KRB5_AUTH always being set).

I hope the patch is OK.
The configure file was manually patched because I cannot regenerate
one properly with my current autoconf.


Do you think it should be shipped with INN 2.4.4?
And is it worth putting again a 4th RC on ftp.isc.org for only that change?
(Only the --with-kerberos recognization would change).

Julien


> I compiled on a Fedora Core 5 box, and the 'Make' process could not find com_err.h. \
> I found this file in /usr/include/et and  copied it to /usr/include where Make \
> could find it, and the compilation worked fine then.

----- Message d'origine ----- 
De : "Julien ÉLIE" <iulius@nom-de-mon-site.com.invalid>
Groupes de discussion : news.software.nntp
Envoyé : mardi 29 avril 2008 12:28
Objet : Re: NNTP over SSL/TLS using INN 2.4.3


> Hi Bozweb,
> 
> > > > There is a bug in auth_krb5.c
> > > 
> > > Or a problem with configure?
> > > I have HAVE_ET_COM_ERR_H set if <et/com_err.h> exists.
> > > 
> > > What does config.log say?
> > 
> > Nothing in config.log
> > Configure  --with-perl on a centos 5.1
> 
> Hmm...  auth_krb5.c should normally be dealt with only if "--with-kerberos"
> is also given to configure.
> 
> I see that KRB5_AUTH is set in Makefile.global even though we do not want
> Kerberos.  It affects INN 2.4.x but it was fixed in INN 2.5.
> 
> 
> Perhaps something like that should fix the problem for INN 2.4.x but
> it is more a kludge than anything else:
> 
> Index: configure
> ===================================================================
> --- configure   (révision 7765)
> +++ configure   (copie de travail)
> @@ -8054,6 +8054,8 @@
> fi
> 
> 
> +if test "${with_kerberos+set}" = set; then
> +if test x"$with_kerberos" != xno ; then
> 
> inn_save_LIBS=$LIBS
> LIBS=${KRB5_LIB}
> @@ -8223,6 +8225,10 @@
> fi
> done
> 
> +
> +fi
> +fi
> +
> LIBS=$inn_save_LIBS
> 
> if test x"$DO_PERL" = xDO ; then
> 
> 
> Index: configure.in
> ===================================================================
> --- configure.in        (révision 7765)
> +++ configure.in        (copie de travail)
> @@ -818,19 +818,21 @@
> 
> dnl Check for Kerberos libraries for auth_krb5, and if found define KRB5_AUTH
> dnl to the relevant object file, which will enable compilation of it.
> -INN_SEARCH_AUX_LIBS(krb5_parse_name, krb5, KRB5_LIB,
> -    [KRB5_AUTH="auth_krb5"
> -     KRB5_LIB="$KRB5_LDFLAGS $KRB5_LIB -lk5crypto -lcom_err"
> -     AC_SUBST(KRB5_AUTH)
> -     AC_SUBST(KRB5_INC)
> -     AC_CHECK_HEADERS([et/com_err.h])], , [$LIBS -lk5crypto -lcom_err])
> +if test x"$with_kerberos" != xno ; then
> +    INN_SEARCH_AUX_LIBS(krb5_parse_name, krb5, KRB5_LIB,
> +        [KRB5_AUTH="auth_krb5"
> +         KRB5_LIB="$KRB5_LDFLAGS $KRB5_LIB -lk5crypto -lcom_err"
> +         AC_SUBST(KRB5_AUTH)
> +         AC_SUBST(KRB5_INC)
> +         AC_CHECK_HEADERS([et/com_err.h])], , [$LIBS -lk5crypto -lcom_err])
> 
> -dnl Check for necessity of krb5_init_ets
> -dnl OSX does not require this function
> -inn_save_LIBS=$LIBS
> -LIBS=$KRB5_LIB
> -AC_CHECK_FUNCS(krb5_init_ets)
> -LIBS=$inn_save_LIBS
> +    dnl Check for necessity of krb5_init_ets
> +    dnl OSX does not require this function
> +    inn_save_LIBS=$LIBS
> +    LIBS=$KRB5_LIB
> +    AC_CHECK_FUNCS(krb5_init_ets)
> +    LIBS=$inn_save_LIBS
> +fi
> 
> dnl Libraries and flags for embedded Perl.  Some distributions of Linux have
> dnl Perl linked with gdbm but don't normally have gdbm installed, so on that 


[prev in list] [next in list] [prev in thread] [next in thread]