[prev in list] [next in list] [prev in thread] [next in thread] 

List:       inn-workers
Subject:    Re: Possible bg in art.c (new ARTparse stuff)
From:       Russ Allbery <rra () stanford ! edu>
Date:       2004-06-26 20:29:27
Message-ID: 87n02qcbbs.fsf () windlord ! stanford ! edu
[Download RAW message or body]

Christophe Wolfhugel <wolf@oleane.net> writes:

> Shouldn't there i be incremented, else you will log a LF without CR for
> each body line.

Yup, thanks, fixed.

> Also (haven't checked further the code) : are we sure that
> bp->data[i + 1] never goes beyond the bounds ?

See slightly above where you patched.

        /* We saw a \r, which is the beginning of everything interesting.  The
           longest possibly interesting thing we could see is an article
           terminator (five characters).  If we don't have at least five more
           characters, we're guaranteed that the article isn't complete, so
           save ourselves complexity and just return and wait for more
           data. */
        if (bp->used - i < 5) {
            cp->Next = i;
            return;
        }

-- 
Russ Allbery (rra@stanford.edu)             <http://www.eyrie.org/~eagle/>

    Please send questions to the list rather than mailing me directly.
     <http://www.eyrie.org/~eagle/faqs/questions.html> explains why.

[prev in list] [next in list] [prev in thread] [next in thread]