[prev in list] [next in list] [prev in thread] [next in thread] 

List:       illumos-developer
Subject:    [developer] [REVIEW] 16192 Retire libc's thr_debug.h in favor of <sys/debug.h>
From:       "Bill Sommerfeld via illumos-developer" <developer () lists ! illumos ! org>
Date:       2024-04-18 21:03:18
Message-ID: f939912e-7bf8-4fc7-a668-50408e78d7e5 () hamachi ! org
[Download RAW message or body]

Issue: https://www.illumos.org/issues/16192
CR: https://code.illumos.org/c/illumos-gate/+/3237
Diff: 
https://code.illumos.org/~diff/19e663e5fdac288d6652722f057dd1e528fc8bd9

This is followon work to illumos.org/issues/16188, with a set of
code cleanups related to ASSERT in libc.

  - retire thr_debug.h in favor of <sys/debug.h>
  - retire the use of "#ifdef THREAD_DEBUG" in place of "#ifdef DEBUG", 
like most of the rest of illumos-gate.
  - Consistently declare the internal "assfail" function as "void"
rather than sometimes as void and sometimes as int; rework ASSERT
macros using a trick used by thr_debug.h to cope with this.
  - Add __NORETURN annotations to a number of dead-end functions in
libc.  Notably assfail is excluded from this as alternate
implementations (in kernel and in libfakekernel) can return in some
cases.

Testing notes are in the bug.








------------------------------------------
illumos: illumos-developer
Permalink: https://illumos.topicbox.com/groups/developer/T00022659108f1713-M91f1ffb81be61c01f6905b53
Delivery options: https://illumos.topicbox.com/groups/developer/subscription
[prev in list] [next in list] [prev in thread] [next in thread]