[prev in list] [next in list] [prev in thread] [next in thread] 

List:       illumos-developer
Subject:    [developer] Review Request 1335: 10165 libzpool: passing argument 1 to restrict-qualified parameter 
From:       "Toomas Soome via illumos-developer" <developer () lists ! illumos ! org>
Date:       2018-12-25 22:05:42
Message-ID: A2986863-1733-462D-946C-6F051C1633CC () me ! com
[Download RAW message or body]

hi!

Please review.

thanks,
toomas

> Begin forwarded message:
> 
> From: Toomas Soome via Review Board <devnull@illumos.org>
> Subject: Review Request 1335: 10165 libzpool: passing argument 1 to \
>                 restrict-qualified parameter aliases with argument 4
> Date: 26 December 2018 at 00:05:17 EET
> To: Joshua Clulow <josh@sysmgr.org>, Vitaliy Gusev <gusev.vitaliy@icloud.com>, \
> Marcel Telka <marcel@telka.sk>, Toomas Soome <tsoome@me.com>, Andy Fiddaman \
> <omnios@citrus-it.co.uk>, Albert Lee <trisk@nexenta.com>, Juraj Lutter \
> <juraj@lutter.sk>, Dan Vatca <dan@syneto.net>, John Howard \
> <Echosoft.LLC@gmail.com>, Norm Jacobs <naj@snapcon.com>, Jason King \
>                 <jason.brian.king+illumos@gmail.com>
> Reply-To: Toomas Soome <tsoome@illumos.org>
> 
> This is an automatically generated e-mail. To reply, visit: \
> https://www.illumos.org/rb/r/1335/ <https://www.illumos.org/rb/r/1335/> Review \
> request for general. By Toomas Soome.
> Bugs: 10165 <https://www.illumos.org/issues/10165>
> Repository: illumos-gate
> Description
> 
> ../../../uts/common/fs/zfs/dsl_dataset.c: In function 'dsl_get_mountpoint':
> ../../../uts/common/fs/zfs/dsl_dataset.c:2186:3: error: passing argument 1 to re
> strict-qualified parameter aliases with argument 4 [-Werror=restrict]
> (void) snprintf(value, ZAP_MAXVALUELEN, "%s", value);
> ^
> cc1: all warnings being treated as errors
> Diffs
> 
> usr/src/uts/common/fs/zfs/dsl_dataset.c (a08477e29ddb137b6f0d113c79c610e16ed9e273)
> View Diff <https://www.illumos.org/rb/r/1335/diff/1/>

------------------------------------------
illumos: illumos-developer
Permalink: https://illumos.topicbox.com/groups/developer/Tcdd0630928c5077c-M5c23bae823ac0c6e35e58380
 Delivery options: https://illumos.topicbox.com/groups/developer/subscription


[Attachment #3 (unknown)]

<html><html><html><head><meta content="text/html; charset=us-ascii" \
http-equiv="Content-Type" /></head><body class="" style="word-wrap: break-word; \
-webkit-nbsp-mode: space; line-break: after-white-space;">hi!<div class=""><br \
class="" /></div><div class="">Please review.</div><div class=""><br class="" \
/></div><div class="">thanks,</div><div class="">toomas<br class="" /><div><br \
class="" /><blockquote class="" type="cite"><div class="">Begin forwarded \
message:</div><br class="Apple-interchange-newline" /><div class="" \
style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: \
0px;"><span class="" style="font-family: -webkit-system-font, Helvetica Neue, \
Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);"><b class="">From: </b></span><span \
class="" style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, \
sans-serif;">Toomas Soome via Review Board &lt;<a class="" \
href="mailto:devnull@illumos.org">devnull@illumos.org</a>&gt;<br class="" \
/></span></div><div class="" style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px;"><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, \
1.0);"><b class="">Subject: </b></span><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif;"><b class="">Review \
Request 1335: 10165 libzpool: passing argument 1 to restrict-qualified parameter \
aliases with argument 4</b><br class="" /></span></div><div class="" \
style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: \
0px;"><span class="" style="font-family: -webkit-system-font, Helvetica Neue, \
Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);"><b class="">Date: </b></span><span \
class="" style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, \
sans-serif;">26 December 2018 at 00:05:17 EET<br class="" /></span></div><div \
class="" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: \
0px;"><span class="" style="font-family: -webkit-system-font, Helvetica Neue, \
Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);"><b class="">To: </b></span><span \
class="" style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, \
sans-serif;">Joshua Clulow &lt;<a class="" \
href="mailto:josh@sysmgr.org">josh@sysmgr.org</a>&gt;, Vitaliy Gusev &lt;<a class="" \
href="mailto:gusev.vitaliy@icloud.com">gusev.vitaliy@icloud.com</a>&gt;, Marcel Telka \
&lt;<a class="" href="mailto:marcel@telka.sk">marcel@telka.sk</a>&gt;, Toomas Soome \
&lt;<a class="" href="mailto:tsoome@me.com">tsoome@me.com</a>&gt;, Andy Fiddaman \
&lt;<a class="" href="mailto:omnios@citrus-it.co.uk">omnios@citrus-it.co.uk</a>&gt;, \
Albert Lee &lt;<a class="" href="mailto:trisk@nexenta.com">trisk@nexenta.com</a>&gt;, \
Juraj Lutter &lt;<a class="" href="mailto:juraj@lutter.sk">juraj@lutter.sk</a>&gt;, \
Dan Vatca &lt;<a class="" href="mailto:dan@syneto.net">dan@syneto.net</a>&gt;, John \
Howard &lt;<a class="" \
href="mailto:Echosoft.LLC@gmail.com">Echosoft.LLC@gmail.com</a>&gt;, Norm Jacobs \
&lt;<a class="" href="mailto:naj@snapcon.com">naj@snapcon.com</a>&gt;, Jason King \
&lt;<a class="" href="mailto:jason.brian.king+illumos@gmail.com">jason.brian.king+illumos@gmail.com</a>&gt;<br \
class="" /></span></div><div class="" style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px;"><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, \
1.0);"><b class="">Reply-To: </b></span><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif;">Toomas Soome &lt;<a \
class="" href="mailto:tsoome@illumos.org">tsoome@illumos.org</a>&gt;<br class="" \
/></span></div><br class="" /><div class=""><div class=""><div class="" \
style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"><table bgcolor="#f9f3c9" \
cellpadding="12" class="" style="border: 1px #c9c399 solid; border-radius: 6px; \
-moz-border-radius: 6px; -webkit-border-radius: 6px;" width="100%"><tbody \
class=""><tr class=""><td class="">  This is an automatically generated e-mail. To \
reply, visit:  <a class="" \
href="https://www.illumos.org/rb/r/1335/">https://www.illumos.org/rb/r/1335/</a></td></tr></tbody></table><br \
class="" /><table bgcolor="#fefadf" cellpadding="12" cellspacing="0" class="" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;" width="100%"><tbody class=""><tr class=""><td \
class=""><div class="">Review request for general.</div><div class="">By Toomas \
Soome.</div><div class="" style="margin-top: 1.5em;"><strong class="" style="color: \
#575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </strong>


 <a class="" href="https://www.illumos.org/issues/10165">10165</a></div><div class="" \
style="margin-top: 1.5em;"><strong class="" style="color: #575012; font-size: \
10pt;">Repository: </strong> illumos-gate
</div><h1 class="" style="color: #575012; font-size: 10pt; margin-top: \
1.5em;">Description </h1><table bgcolor="#ffffff" cellpadding="10" cellspacing="0" \
class="" style="border: 1px solid #b8b5a0" width="100%"><tbody class=""><tr \
class=""><td class=""><pre class="" style="margin: 0; padding: 0; white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">../../../uts/common/fs/zfs/dsl_dataset.c: In \
                function &#39;dsl_get_mountpoint&#39;:
../../../uts/common/fs/zfs/dsl_dataset.c:2186:3: error: passing argument 1 to re
strict-qualified parameter aliases with argument 4 [-Werror=restrict]
   (void) snprintf(value, ZAP_MAXVALUELEN, &quot;%s&quot;, value);
   ^
cc1: all warnings being treated as errors</pre></td></tr></tbody></table><h1 class="" \
style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs </h1><ul class="" \
style="margin-left: 3em; padding-left: 0;"><li \
class="">usr/src/uts/common/fs/zfs/dsl_dataset.c <span class="" style="color: \
grey">(a08477e29ddb137b6f0d113c79c610e16ed9e273)</span></ul><p class=""><a class="" \
href="https://www.illumos.org/rb/r/1335/diff/1/" style="margin-left: 3em;">View \
Diff</a></td></tr></tbody></table></div></div></div></blockquote></div><br class="" \
/></div><div id="topicbox-footer" style="margin:10px 0 0;border-top:1px solid \
#ddd;border-color:rgba(0,0,0,.15);padding:7px 0;">

<strong><a href="https://illumos.topicbox.com/latest" \
style="color:inherit;text-decoration:none">illumos</a></strong>  / illumos-developer \
/ see <a href="https://illumos.topicbox.com/groups/developer">discussions</a>
  +
<a href="https://illumos.topicbox.com/groups/developer/members">participants</a>
  +
<a href="https://illumos.topicbox.com/groups/developer/subscription">delivery \
options</a> <a href="https://illumos.topicbox.com/groups/developer/Tcdd0630928c5077c-M5c23bae823ac0c6e35e58380" \
style="float:right">Permalink</a> </div>
</body></html></html></html>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic