[prev in list] [next in list] [prev in thread] [next in thread]
List: illumos-developer
Subject: [developer] Review Request 1333: 10163 ufs_fsck: bitwise comparison always evaluates to false
From: "Toomas Soome via illumos-developer" <developer () lists ! illumos ! org>
Date: 2018-12-25 20:46:47
Message-ID: 69EF3AF3-2EA3-4654-A14F-D1C83B7BDF0E () me ! com
[Download RAW message or body]
hi!
Please review.
thanks.
toomas
> Begin forwarded message:
>
> From: Toomas Soome via Review Board <devnull@illumos.org>
> Subject: Review Request 1333: 10163 ufs_fsck: bitwise comparison always evaluates \
> to false
> Date: 25 December 2018 at 22:46:04 EET
> To: Joshua Clulow <josh@sysmgr.org>, Vitaliy Gusev <gusev.vitaliy@icloud.com>, \
> Marcel Telka <marcel@telka.sk>, Toomas Soome <tsoome@me.com>, Andy Fiddaman \
> <omnios@citrus-it.co.uk>, Albert Lee <trisk@nexenta.com>, Juraj Lutter \
> <juraj@lutter.sk>, Dan Vatca <dan@syneto.net>, John Howard \
> <Echosoft.LLC@gmail.com>, Norm Jacobs <naj@snapcon.com>, Jason King \
> <jason.brian.king+illumos@gmail.com>
> Reply-To: Toomas Soome <tsoome@illumos.org>
>
> This is an automatically generated e-mail. To reply, visit: \
> https://www.illumos.org/rb/r/1333/ <https://www.illumos.org/rb/r/1333/> Review \
> request for general. By Toomas Soome.
> Bugs: 10163 <https://www.illumos.org/issues/10163>
> Repository: illumos-gate
> Description
>
> pass2.c: In function 'pass2':
> pass2.c:243:42: error: bitwise comparison always evaluates to false \
> [-Werror=tautological-compare] if ((statemap[inp->i_number] & STMASK) == DCLEAR ||
> ^~
> cc1: all warnings being treated as errors
> Diffs
>
> usr/src/cmd/fs.d/ufs/fsck/pass2.c (998f98f3f6ee28db1dc3555ceb3625978f13f5cd)
> View Diff <https://www.illumos.org/rb/r/1333/diff/1/>
------------------------------------------
illumos: illumos-developer
Permalink: https://illumos.topicbox.com/groups/developer/Te7afd87212435774-M765c0193192a5c6602e69589
Delivery options: https://illumos.topicbox.com/groups/developer/subscription
[Attachment #3 (unknown)]
<html><html><html><head><meta content="text/html; charset=us-ascii" \
http-equiv="Content-Type" /></head><body class="" style="word-wrap: break-word; \
-webkit-nbsp-mode: space; line-break: after-white-space;">hi!<div class=""><br \
class="" /></div><div class="">Please review.</div><div class=""><br class="" \
/></div><div class="">thanks.</div><div class="">toomas<br class="" /><div><br \
class="" /><blockquote class="" type="cite"><div class="">Begin forwarded \
message:</div><br class="Apple-interchange-newline" /><div class="" \
style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: \
0px;"><span class="" style="font-family: -webkit-system-font, Helvetica Neue, \
Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);"><b class="">From: </b></span><span \
class="" style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, \
sans-serif;">Toomas Soome via Review Board <<a class="" \
href="mailto:devnull@illumos.org">devnull@illumos.org</a>><br class="" \
/></span></div><div class="" style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px;"><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, \
1.0);"><b class="">Subject: </b></span><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif;"><b class="">Review \
Request 1333: 10163 ufs_fsck: bitwise comparison always evaluates to false</b><br \
class="" /></span></div><div class="" style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px;"><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, \
1.0);"><b class="">Date: </b></span><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif;">25 December 2018 at \
22:46:04 EET<br class="" /></span></div><div class="" style="margin-top: 0px; \
margin-right: 0px; margin-bottom: 0px; margin-left: 0px;"><span class="" \
style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; \
color:rgba(0, 0, 0, 1.0);"><b class="">To: </b></span><span class="" \
style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, \
sans-serif;">Joshua Clulow <<a class="" \
href="mailto:josh@sysmgr.org">josh@sysmgr.org</a>>, Vitaliy Gusev <<a class="" \
href="mailto:gusev.vitaliy@icloud.com">gusev.vitaliy@icloud.com</a>>, Marcel Telka \
<<a class="" href="mailto:marcel@telka.sk">marcel@telka.sk</a>>, Toomas Soome \
<<a class="" href="mailto:tsoome@me.com">tsoome@me.com</a>>, Andy Fiddaman \
<<a class="" href="mailto:omnios@citrus-it.co.uk">omnios@citrus-it.co.uk</a>>, \
Albert Lee <<a class="" href="mailto:trisk@nexenta.com">trisk@nexenta.com</a>>, \
Juraj Lutter <<a class="" href="mailto:juraj@lutter.sk">juraj@lutter.sk</a>>, \
Dan Vatca <<a class="" href="mailto:dan@syneto.net">dan@syneto.net</a>>, John \
Howard <<a class="" \
href="mailto:Echosoft.LLC@gmail.com">Echosoft.LLC@gmail.com</a>>, Norm Jacobs \
<<a class="" href="mailto:naj@snapcon.com">naj@snapcon.com</a>>, Jason King \
<<a class="" href="mailto:jason.brian.king+illumos@gmail.com">jason.brian.king+illumos@gmail.com</a>><br \
class="" /></span></div><div class="" style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px;"><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, \
1.0);"><b class="">Reply-To: </b></span><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif;">Toomas Soome <<a \
class="" href="mailto:tsoome@illumos.org">tsoome@illumos.org</a>><br class="" \
/></span></div><br class="" /><div class=""><div class=""><div class="" \
style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"><table bgcolor="#f9f3c9" \
cellpadding="12" class="" style="border: 1px #c9c399 solid; border-radius: 6px; \
-moz-border-radius: 6px; -webkit-border-radius: 6px;" width="100%"><tbody \
class=""><tr class=""><td class=""> This is an automatically generated e-mail. To \
reply, visit: <a class="" \
href="https://www.illumos.org/rb/r/1333/">https://www.illumos.org/rb/r/1333/</a></td></tr></tbody></table><br \
class="" /><table bgcolor="#fefadf" cellpadding="12" cellspacing="0" class="" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;" width="100%"><tbody class=""><tr class=""><td \
class=""><div class="">Review request for general.</div><div class="">By Toomas \
Soome.</div><div class="" style="margin-top: 1.5em;"><strong class="" style="color: \
#575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </strong>
<a class="" href="https://www.illumos.org/issues/10163">10163</a></div><div class="" \
style="margin-top: 1.5em;"><strong class="" style="color: #575012; font-size: \
10pt;">Repository: </strong> illumos-gate
</div><h1 class="" style="color: #575012; font-size: 10pt; margin-top: \
1.5em;">Description </h1><table bgcolor="#ffffff" cellpadding="10" cellspacing="0" \
class="" style="border: 1px solid #b8b5a0" width="100%"><tbody class=""><tr \
class=""><td class=""><pre class="" style="margin: 0; padding: 0; white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">pass2.c: In function 'pass2': \
pass2.c:243:42: error: bitwise comparison always evaluates to false \
[-Werror=tautological-compare] if ((statemap[inp->i_number] & STMASK) == \
DCLEAR || ^~
cc1: all warnings being treated as errors</pre></td></tr></tbody></table><h1 class="" \
style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs </h1><ul class="" \
style="margin-left: 3em; padding-left: 0;"><li \
class="">usr/src/cmd/fs.d/ufs/fsck/pass2.c <span class="" style="color: \
grey">(998f98f3f6ee28db1dc3555ceb3625978f13f5cd)</span></ul><p class=""><a class="" \
href="https://www.illumos.org/rb/r/1333/diff/1/" style="margin-left: 3em;">View \
Diff</a></td></tr></tbody></table></div></div></div></blockquote></div><br class="" \
/></div><div id="topicbox-footer" style="margin:10px 0 0;border-top:1px solid \
#ddd;border-color:rgba(0,0,0,.15);padding:7px 0;">
<strong><a href="https://illumos.topicbox.com/latest" \
style="color:inherit;text-decoration:none">illumos</a></strong> / illumos-developer \
/ see <a href="https://illumos.topicbox.com/groups/developer">discussions</a>
+
<a href="https://illumos.topicbox.com/groups/developer/members">participants</a>
+
<a href="https://illumos.topicbox.com/groups/developer/subscription">delivery \
options</a> <a href="https://illumos.topicbox.com/groups/developer/Te7afd87212435774-M765c0193192a5c6602e69589" \
style="float:right">Permalink</a> </div>
</body></html></html></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic