[prev in list] [next in list] [prev in thread] [next in thread]
List: illumos-developer
Subject: [developer] Review Request 1139: 9665 loader: UEFI loader needs to set ISADIR based on hardware
From: "Toomas Soome via illumos-developer" <developer () lists ! illumos ! org>
Date: 2018-07-19 8:36:04
Message-ID: 5A986459-C06D-4F56-A22A-62A289CC6FD9 () me ! com
[Download RAW message or body]
hi!
Please review. This is followup to 9664 - set ISADIR based on actual hardware.
thanks,
toomas
> Begin forwarded message:
>
> From: Toomas Soome via Review Board <devnull@illumos.org>
> Subject: Review Request 1139: 9665 loader: UEFI loader needs to set ISADIR based on \
> hardware
> Date: 19 July 2018 at 11:22:46 EEST
> To: Joshua Clulow <josh@sysmgr.org>, Vitaliy Gusev <gusev.vitaliy@icloud.com>, \
> Marcel Telka <marcel@telka.sk>, Andy Fiddaman <af@citrus-it.net>, Toomas Soome \
> <tsoome@me.com>, Albert Lee <trisk@nexenta.com>, Juraj Lutter <juraj@lutter.sk>, \
> Dan Vatca <dan@syneto.net>, John Howard <Echosoft.LLC@gmail.com>, Norm Jacobs \
> <naj@snapcon.com>
> Reply-To: Toomas Soome <tsoome@illumos.org>
>
> This is an automatically generated e-mail. To reply, visit: \
> https://www.illumos.org/rb/r/1139/ <https://www.illumos.org/rb/r/1139/> Review \
> request for general. By Toomas Soome.
> Bugs: 9665 <https://www.illumos.org/issues/9665>
> Repository: illumos-gate
> Description
>
> 9665 loader: UEFI loader needs to set ISADIR based on hardware
> Testing
>
> Lenovo MIIX300 & qemu for 32-bit systems and various 64-bit systems I have access \
> to. Diffs
>
> usr/src/boot/sys/boot/efi/loader/main.c (fe4281ee3cee6ef7b5b72d2f85d58af6f01d1bc2)
> usr/src/boot/sys/boot/efi/loader/loader_efi.h \
> (7339515b6b538d3786acfaaf0e112dd767646e58) \
> usr/src/boot/sys/boot/efi/loader/arch/i386/bootinfo64.c (PRE-CREATION) \
> usr/src/boot/sys/boot/efi/loader/arch/i386/Makefile.inc \
> (4e08c5376336243df2d5bf13c2ee0e85c073e7ce) \
> usr/src/boot/sys/boot/efi/loader/arch/amd64/bootinfo64.c (PRE-CREATION) \
> usr/src/boot/sys/boot/efi/loader/arch/amd64/Makefile.inc \
> (47dd322f91c6600f0b7b38272e3004e7004f08d5) View Diff \
> <https://www.illumos.org/rb/r/1139/diff/1/>
------------------------------------------
illumos: illumos-developer
Permalink: https://illumos.topicbox.com/groups/developer/T90996cc3fcba7b03-M016ab522f7d37011bfa29bac
Delivery options: https://illumos.topicbox.com/groups/developer/subscription
[Attachment #3 (unknown)]
<html><html><html><head><meta content="text/html; charset=us-ascii" \
http-equiv="Content-Type" /></head><body class="" style="word-wrap: break-word; \
-webkit-nbsp-mode: space; line-break: after-white-space;">hi!<div class=""><br \
class="" /></div><div class="">Please review. This is followup to 9664 - set ISADIR \
based on actual hardware.</div><div class=""><br class="" /></div><div \
class="">thanks,</div><div class="">toomas<br class="" /><div><br class="" \
/><blockquote class="" type="cite"><div class="">Begin forwarded message:</div><br \
class="Apple-interchange-newline" /><div class="" style="margin-top: 0px; \
margin-right: 0px; margin-bottom: 0px; margin-left: 0px;"><span class="" \
style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; \
color:rgba(0, 0, 0, 1.0);"><b class="">From: </b></span><span class="" \
style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, \
sans-serif;">Toomas Soome via Review Board <<a class="" \
href="mailto:devnull@illumos.org">devnull@illumos.org</a>><br class="" \
/></span></div><div class="" style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px;"><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, \
1.0);"><b class="">Subject: </b></span><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif;"><b class="">Review \
Request 1139: 9665 loader: UEFI loader needs to set ISADIR based on hardware</b><br \
class="" /></span></div><div class="" style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px;"><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, \
1.0);"><b class="">Date: </b></span><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif;">19 July 2018 at 11:22:46 \
EEST<br class="" /></span></div><div class="" style="margin-top: 0px; margin-right: \
0px; margin-bottom: 0px; margin-left: 0px;"><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, \
1.0);"><b class="">To: </b></span><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif;">Joshua Clulow <<a \
class="" href="mailto:josh@sysmgr.org">josh@sysmgr.org</a>>, Vitaliy Gusev <<a \
class="" href="mailto:gusev.vitaliy@icloud.com">gusev.vitaliy@icloud.com</a>>, \
Marcel Telka <<a class="" href="mailto:marcel@telka.sk">marcel@telka.sk</a>>, \
Andy Fiddaman <<a class="" \
href="mailto:af@citrus-it.net">af@citrus-it.net</a>>, Toomas Soome <<a class="" \
href="mailto:tsoome@me.com">tsoome@me.com</a>>, Albert Lee <<a class="" \
href="mailto:trisk@nexenta.com">trisk@nexenta.com</a>>, Juraj Lutter <<a \
class="" href="mailto:juraj@lutter.sk">juraj@lutter.sk</a>>, Dan Vatca <<a \
class="" href="mailto:dan@syneto.net">dan@syneto.net</a>>, John Howard <<a \
class="" href="mailto:Echosoft.LLC@gmail.com">Echosoft.LLC@gmail.com</a>>, Norm \
Jacobs <<a class="" href="mailto:naj@snapcon.com">naj@snapcon.com</a>><br \
class="" /></span></div><div class="" style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px;"><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, \
1.0);"><b class="">Reply-To: </b></span><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif;">Toomas Soome <<a \
class="" href="mailto:tsoome@illumos.org">tsoome@illumos.org</a>><br class="" \
/></span></div><br class="" /><div class=""><div class=""><div class="" \
style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"><table bgcolor="#f9f3c9" \
cellpadding="12" class="" style="border: 1px #c9c399 solid; border-radius: 6px; \
-moz-border-radius: 6px; -webkit-border-radius: 6px;" width="100%"><tbody \
class=""><tr class=""><td class=""> This is an automatically generated e-mail. To \
reply, visit: <a class="" \
href="https://www.illumos.org/rb/r/1139/">https://www.illumos.org/rb/r/1139/</a></td></tr></tbody></table><br \
class="" /><table bgcolor="#fefadf" cellpadding="12" cellspacing="0" class="" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;" width="100%"><tbody class=""><tr class=""><td \
class=""><div class="">Review request for general.</div><div class="">By Toomas \
Soome.</div><div class="" style="margin-top: 1.5em;"><strong class="" style="color: \
#575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </strong>
<a class="" href="https://www.illumos.org/issues/9665">9665</a></div><div class="" \
style="margin-top: 1.5em;"><strong class="" style="color: #575012; font-size: \
10pt;">Repository: </strong> illumos-gate
</div><h1 class="" style="color: #575012; font-size: 10pt; margin-top: \
1.5em;">Description </h1><table bgcolor="#ffffff" cellpadding="10" cellspacing="0" \
class="" style="border: 1px solid #b8b5a0" width="100%"><tbody class=""><tr \
class=""><td class=""><pre class="" style="margin: 0; padding: 0; white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">9665 loader: UEFI loader needs to set ISADIR \
based on hardware</pre></td></tr></tbody></table><h1 class="" style="color: #575012; \
font-size: 10pt; margin-top: 1.5em;">Testing </h1><table bgcolor="#ffffff" \
cellpadding="10" cellspacing="0" class="" style="border: 1px solid #b8b5a0" \
width="100%"><tbody class=""><tr class=""><td class=""><pre class="" style="margin: \
0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><div class="" \
style="padding: 0px; text-rendering: inherit; margin: 0px; line-height: inherit; \
white-space: inherit;">Lenovo MIIX300 & qemu for 32-bit systems and various \
64-bit systems I have access to.</div></pre></td></tr></tbody></table><h1 class="" \
style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs </h1><ul class="" \
style="margin-left: 3em; padding-left: 0;"><li \
class="">usr/src/boot/sys/boot/efi/loader/main.c <span class="" style="color: \
grey">(fe4281ee3cee6ef7b5b72d2f85d58af6f01d1bc2)</span><li \
class="">usr/src/boot/sys/boot/efi/loader/loader_efi.h <span class="" style="color: \
grey">(7339515b6b538d3786acfaaf0e112dd767646e58)</span><li \
class="">usr/src/boot/sys/boot/efi/loader/arch/i386/bootinfo64.c <span class="" \
style="color: grey">(PRE-CREATION)</span><li \
class="">usr/src/boot/sys/boot/efi/loader/arch/i386/Makefile.inc <span class="" \
style="color: grey">(4e08c5376336243df2d5bf13c2ee0e85c073e7ce)</span><li \
class="">usr/src/boot/sys/boot/efi/loader/arch/amd64/bootinfo64.c <span class="" \
style="color: grey">(PRE-CREATION)</span><li \
class="">usr/src/boot/sys/boot/efi/loader/arch/amd64/Makefile.inc <span class="" \
style="color: grey">(47dd322f91c6600f0b7b38272e3004e7004f08d5)</span></ul><p \
class=""><a class="" href="https://www.illumos.org/rb/r/1139/diff/1/" \
style="margin-left: 3em;">View \
Diff</a></td></tr></tbody></table></div></div></div></blockquote></div><br class="" \
/></div><div id="topicbox-footer" style="margin:10px 0 0;border-top:1px solid \
#ddd;border-color:rgba(0,0,0,.15);padding:7px 0;">
<strong><a href="https://illumos.topicbox.com/latest" \
style="color:inherit;text-decoration:none">illumos</a></strong> / illumos-developer \
/ see <a href="https://illumos.topicbox.com/groups/developer">discussions</a>
+
<a href="https://illumos.topicbox.com/groups/developer/members">participants</a>
+
<a href="https://illumos.topicbox.com/groups/developer/subscription">delivery \
options</a> <a href="https://illumos.topicbox.com/groups/developer/T90996cc3fcba7b03-M016ab522f7d37011bfa29bac" \
style="float:right">Permalink</a> </div>
</body></html></html></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic