[prev in list] [next in list] [prev in thread] [next in thread] 

List:       illumos-developer
Subject:    Re: [developer] Review Request: 9502 expose thresholds as properties on sensor facility nodes
From:       Dale Ghent <daleg () elemental ! org>
Date:       2018-04-26 21:37:10
Message-ID: 54B42CE1-D0BA-46FB-A04C-B6531C6F5E10 () elemental ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


+1 LGTM

> On Apr 26, 2018, at 12:45 AM, Rob Johnston <rob.johnston@joyent.com> wrote:
> 
> This is a review request for the following small change affecting libtopo and \
> libipmi: 
> 9502 expose thresholds as properties on sensor facility nodes
> 
> This change exposes the upper and lower thresholds (if set) as properties on the \
> corresponding sensor facility node in the hc-scheme topo tree.  For example: 
> hc://:product-id=X9SCL-X9SCM:server-id=ivy:chassis-id=0123456789/chassis=0/fan=0?sensor=FAN \
>                 1
> group: facility                       version: 1   stability: Private/Private
> entity_ref        string[]  [ "FAN 1" ]
> sensor-class      string    threshold
> type              uint32    0x101 (THRESHOLD_STATE)
> state             uint32    0xc0 (0xc0)
> reading           double    4800.000000
> units             uint32    0x12 (RPM)
> threshold-lower-non-critical double    600.000000
> threshold-lower-critical double    450.000000
> threshold-lower-non-recoverable double    300.000000
> threshold-upper-non-critical double    18975.000000
> threshold-upper-critical double    19050.000000
> threshold-upper-non-recoverable double    19125.000000
> 
> This is a port of a change that I already integrated into illumos-joyent via the \
> commit below: 
> commit 414afefe58a0a3292d2689bd10360ebb4b505ca6
> Author: Rob Johnston <rob.johnston@joyent.com>
> Date:   Mon Mar 5 21:47:01 2018 +0000
> 
> OS-6732 expose thresholds as properties on sensor facility nodes
> Reviewed by: Robert Mustacchi <rm@joyent.com>
> Approved by: Jason King <jason.king@joyent.com>
> 
> The illumos-joent change patched over to illumos-gate cleanly.  No manual \
> intervention was required.  webrev is here: 
> http://72.2.119.57/webrevs/webrev.9502/
> 
> thanks,
> 
> rob
> 
> ------------------------------------------
> illumos: illumos-developer
> Permalink: https://illumos.topicbox.com/groups/developer/discussions/Te1c450805900252a-M7037896152692e3809b7e32b
>  Delivery options: https://illumos.topicbox.com/groups


["signature.asc" (signature.asc)]

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEETxs6KjouZpvOptP6/9WqfD9s72EFAlriRocACgkQ/9WqfD9s
72F1ng/8DEKAe1bqFfiqp4sk6j2AUvHZyjygjHjyqDrYpr7UaFP8ewkcvPy6e1o+
LtQPWwEOCTc4qIaLDXfOZv8vZRu2fteKzNELIXZ4zSVrsl+IFEnYy61dKFcSaxI4
qUuvXGeAnuUd5DdJ/KPKkkW6NeAAGKx9lxllf4HWS1xvxNzjZEBPa0C1S130YC9o
DNuCnzQzIzfn1Yd/z3QvKs4hRmKwJY+OOMBNJBsdIpNOxvpt7I+ifyXk6tW/6Q8X
rUlTnTaYg3+iTg0X46zr5giWMqREk3gBV4m/8EgRomem02ll7qJnyh8A1rS9pRRl
q2EWTY+po+eTMmjnDP8mGCJc9Ukks9g8V9WrJHzOMPiGmFPhGkyirglOE8qPm/hu
KxyGIZu/r/Y/GGYyVT/29oYGZwFQzZxlYD5q82WZwyQOOZzqlI5G7Wrrsl1tUSbs
GfSXcuDM+sP5yOieQw59PpuueFFKWHdaj4wjl7zHNhV0fM7vpkarr/IT4rF56+9i
/oenck3c62YucljXzKSWuqNmhKelmKVc5MfOxWFi6Q5EJ1VRbT4RuZV2QFDFgpKO
hxZXFRuUuUQy9FsC+kA7S1oMvGvkPrywRBQOjTanr5ZNkB4ZqFQj7Dr3EPodZ+Bv
KPFqiZcAHiouaeK8z29COtcwBs9QCg6JMArArHSDgrfrqW0aklI=
=h5ur
-----END PGP SIGNATURE-----


------------------------------------------
illumos: illumos-developer
Permalink: https://illumos.topicbox.com/groups/developer/discussions/Te1c45=
0805900252a-M00d30f02799449397a6ace84
Delivery options: https://illumos.topicbox.com/groups


[prev in list] [next in list] [prev in thread] [next in thread]