[prev in list] [next in list] [prev in thread] [next in thread]
List: illumos-developer
Subject: [developer] Review Request 1075: 9476 loader: Don't leak memory when displaying help.
From: Toomas Soome <tsoome () me ! com>
Date: 2018-04-15 7:34:49
Message-ID: 5E9130C2-4FBD-4F36-B9A9-38CFE817DD39 () me ! com
[Download RAW message or body]
hi!
please review. cleaning coverity findings.
thanks,
toomas
> Begin forwarded message:
>
> From: Toomas Soome <tsoome@illumos.org>
> Subject: Review Request 1075: 9476 loader: Don't leak memory when displaying help.
> Date: 15 April 2018 at 10:33:54 EEST
> To: Joshua Clulow <josh@sysmgr.org>, Vitaliy Gusev <gusev.vitaliy@icloud.com>, \
> Marcel Telka <marcel@telka.sk>, Andy Fiddaman <af@citrus-it.net>, Toomas Soome \
> <tsoome@me.com>, Yuri Pankov <yuripv@yuripv.net>, Albert Lee <trisk@nexenta.com>, \
> Juraj Lutter <juraj@lutter.sk>, Dan Vatca <dan@syneto.net>, John Howard \
> <Echosoft.LLC@gmail.com>, Norm Jacobs <naj@snapcon.com>
> Reply-To: Toomas Soome <tsoome@illumos.org>
>
> This is an automatically generated e-mail. To reply, visit: \
> https://www.illumos.org/rb/r/1075/ <https://www.illumos.org/rb/r/1075/> Review \
> request for general. By Toomas Soome.
> Bugs: 9476 <https://www.illumos.org/issues/9476>
> Repository: illumos-gate
> Description
>
> FreeBSD update: https://svnweb.freebsd.org/base?view=revision&revision=328289
>
> Right now, we'll leak memory when we display a help topic because we
> don't free t, s, d that we've just used when breaking out of the loop.
> NB: coverity just reported t, but s and d also leak.
>
> CID: 1007776
> Diffs
>
> usr/src/common/ficl/emu/loader_emu.c (d109016176a317654794a4e0ac0faf1955d13e89)
> usr/src/boot/sys/boot/common/commands.c (65941a2f2b55f3dff70c4ea6542ded5b9e29a34d)
> View Diff <https://www.illumos.org/rb/r/1075/diff/1/>
------------------------------------------
illumos: illumos-developer
Permalink: https://illumos.topicbox.com/groups/developer/discussions/T1915d93c1a673c70-M88e600dd110e3762268713e0
Delivery options: https://illumos.topicbox.com/groups
[Attachment #3 (unknown)]
<html><html><html><head><meta content="text/html; charset=us-ascii" \
http-equiv="Content-Type" /></head><body class="" style="word-wrap: break-word; \
-webkit-nbsp-mode: space; line-break: after-white-space;">hi!<div class=""><br \
class="" /></div><div class="">please review. cleaning coverity findings.</div><div \
class=""><br class="" /></div><div class="">thanks,</div><div class="">toomas<br \
class="" /><div><br class="" /><blockquote class="" type="cite"><div class="">Begin \
forwarded message:</div><br class="Apple-interchange-newline" /><div class="" \
style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: \
0px;"><span class="" style="font-family: -webkit-system-font, Helvetica Neue, \
Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);"><b class="">From: </b></span><span \
class="" style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, \
sans-serif;">Toomas Soome <<a class="" \
href="mailto:tsoome@illumos.org">tsoome@illumos.org</a>><br class="" \
/></span></div><div class="" style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px;"><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, \
1.0);"><b class="">Subject: </b></span><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif;"><b class="">Review \
Request 1075: 9476 loader: Don't leak memory when displaying help.</b><br \
class="" /></span></div><div class="" style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px;"><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, \
1.0);"><b class="">Date: </b></span><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif;">15 April 2018 at \
10:33:54 EEST<br class="" /></span></div><div class="" style="margin-top: 0px; \
margin-right: 0px; margin-bottom: 0px; margin-left: 0px;"><span class="" \
style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; \
color:rgba(0, 0, 0, 1.0);"><b class="">To: </b></span><span class="" \
style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, \
sans-serif;">Joshua Clulow <<a class="" \
href="mailto:josh@sysmgr.org">josh@sysmgr.org</a>>, Vitaliy Gusev <<a class="" \
href="mailto:gusev.vitaliy@icloud.com">gusev.vitaliy@icloud.com</a>>, Marcel Telka \
<<a class="" href="mailto:marcel@telka.sk">marcel@telka.sk</a>>, Andy Fiddaman \
<<a class="" href="mailto:af@citrus-it.net">af@citrus-it.net</a>>, Toomas Soome \
<<a class="" href="mailto:tsoome@me.com">tsoome@me.com</a>>, Yuri Pankov <<a \
class="" href="mailto:yuripv@yuripv.net">yuripv@yuripv.net</a>>, Albert Lee <<a \
class="" href="mailto:trisk@nexenta.com">trisk@nexenta.com</a>>, Juraj Lutter \
<<a class="" href="mailto:juraj@lutter.sk">juraj@lutter.sk</a>>, Dan Vatca \
<<a class="" href="mailto:dan@syneto.net">dan@syneto.net</a>>, John Howard \
<<a class="" href="mailto:Echosoft.LLC@gmail.com">Echosoft.LLC@gmail.com</a>>, \
Norm Jacobs <<a class="" href="mailto:naj@snapcon.com">naj@snapcon.com</a>><br \
class="" /></span></div><div class="" style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px;"><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, \
1.0);"><b class="">Reply-To: </b></span><span class="" style="font-family: \
-webkit-system-font, Helvetica Neue, Helvetica, sans-serif;">Toomas Soome <<a \
class="" href="mailto:tsoome@illumos.org">tsoome@illumos.org</a>><br class="" \
/></span></div><br class="" /><div class=""><div class=""><div class="" \
style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"><table bgcolor="#f9f3c9" \
cellpadding="12" class="" style="border: 1px #c9c399 solid; border-radius: 6px; \
-moz-border-radius: 6px; -webkit-border-radius: 6px;" width="100%"><tbody \
class=""><tr class=""><td class=""> This is an automatically generated e-mail. To \
reply, visit: <a class="" \
href="https://www.illumos.org/rb/r/1075/">https://www.illumos.org/rb/r/1075/</a></td></tr></tbody></table><br \
class="" /><table bgcolor="#fefadf" cellpadding="12" cellspacing="0" class="" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;" width="100%"><tbody class=""><tr class=""><td \
class=""><div class="">Review request for general.</div><div class="">By Toomas \
Soome.</div><div class="" style="margin-top: 1.5em;"><strong class="" style="color: \
#575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </strong>
<a class="" href="https://www.illumos.org/issues/9476">9476</a></div><div class="" \
style="margin-top: 1.5em;"><strong class="" style="color: #575012; font-size: \
10pt;">Repository: </strong> illumos-gate
</div><h1 class="" style="color: #575012; font-size: 10pt; margin-top: \
1.5em;">Description </h1><table bgcolor="#ffffff" cellpadding="10" cellspacing="0" \
class="" style="border: 1px solid #b8b5a0" width="100%"><tbody class=""><tr \
class=""><td class=""><pre class="" style="margin: 0; padding: 0; white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">FreeBSD update: <a class="" \
href="https://svnweb.freebsd.org/base?view=revision&revision=328289">https://svnweb.freebsd.org/base?view=revision&revision=328289</a>
Right now, we'll leak memory when we display a help topic because we
don't free t, s, d that we've just used when breaking out of the loop.
NB: coverity just reported t, but s and d also leak.
CID: 1007776</pre></td></tr></tbody></table><h1 class="" style="color: #575012; \
font-size: 10pt; margin-top: 1.5em;">Diffs </h1><ul class="" style="margin-left: 3em; \
padding-left: 0;"><li class="">usr/src/common/ficl/emu/loader_emu.c <span class="" \
style="color: grey">(d109016176a317654794a4e0ac0faf1955d13e89)</span><li \
class="">usr/src/boot/sys/boot/common/commands.c <span class="" style="color: \
grey">(65941a2f2b55f3dff70c4ea6542ded5b9e29a34d)</span></ul><p class=""><a class="" \
href="https://www.illumos.org/rb/r/1075/diff/1/" style="margin-left: 3em;">View \
Diff</a></td></tr></tbody></table></div></div></div></blockquote></div><br class="" \
/></div><div id="topicbox-footer" style="margin:10px 0 0;border-top:1px solid \
#ddd;border-color:rgba(0,0,0,.15);padding:7px 0;">
<strong><a href="https://illumos.topicbox.com/latest" \
style="color:inherit;text-decoration:none">illumos</a></strong> /
<a href="https://illumos.topicbox.com/groups/developer/members">illumos-developer</a>
/
<a href="https://illumos.topicbox.com/groups/developer/discussions/T1915d93c1a673c70-M88e600dd110e3762268713e0">Permalink</a>
<a href="https://illumos.topicbox.com/groups" style="float:right">Delivery \
options</a> </div>
</body></html></html></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic